From: linuxtestproject.agent@gmail.com
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] build.sh: Add support for test-metadata
Date: Thu, 9 Jul 2026 13:53:57 +0000 [thread overview]
Message-ID: <20260709135357.4124-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260709130135.927868-2-pvorel@suse.cz>
Hi Petr,
On Thu, Jul 09, 2026 at 15:01:33 +0200, Petr Vorel wrote:
> build.sh: Add support for test-metadata
--- [PATCH 1/3] ---
The commit body is empty. Is there anything worth saying about why
test-metadata deserves its own run-type, or why it is being added now?
Even one sentence would help readers understand the motivation without
having to read the whole series.
--- [PATCH 3/3] ---
> printf "* $i "
$i is expanded directly into printf's format string. If a .c file
is ever added whose name contains a percent sign, printf will interpret
it as a format specifier and produce garbled output.
The portable form is:
printf '* %s ' "$i"
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-07-09 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 13:01 [LTP] [PATCH 0/3] CI: Run metadata tests Petr Vorel
2026-07-09 13:01 ` [LTP] [PATCH 1/3] build.sh: Add support for test-metadata Petr Vorel
2026-07-09 13:53 ` linuxtestproject.agent [this message]
2026-07-09 15:07 ` [LTP] " Petr Vorel
2026-07-09 13:01 ` [LTP] [PATCH 2/3] ci: Test metadata in docker build testing Petr Vorel
2026-07-09 13:01 ` [LTP] [PATCH 3/3] metadata: test.sh: Print the test name and result Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709135357.4124-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox