From: linuxtestproject.agent@gmail.com
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] test_macros: Add TST_EXP_PASS_OR_FAIL()
Date: Fri, 10 Jul 2026 11:55:21 +0000 [thread overview]
Message-ID: <20260710115521.3898-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260710083337.1185184-1-pvorel@suse.cz>
Hi Petr,
On Fri, Jul 10, 2026, Petr Vorel wrote:
> test_macros: Add TST_EXP_PASS_OR_FAIL()
> + Fix macro parameter name in TST_EXP_FD_OR_FAIL() (upper case).
This is a second, independent logical change bundled into the same
patch. Ground Rule 7 requires exactly one logical change per patch.
The doc-comment fix in TST_EXP_FD_OR_FAIL() should go in a separate
preparatory patch.
> + * TST_EXP_PASS_OR_FAIL() - Test syscall to and expect to pass or fail with
> + * expected errno.
"to and expect" reads as ungrammatical here. Something like:
TST_EXP_PASS_OR_FAIL() - Test syscall to pass or fail with expected errno.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-07-10 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 8:33 [LTP] [PATCH 1/1] test_macros: Add TST_EXP_PASS_OR_FAIL() Petr Vorel
2026-07-10 9:30 ` Cyril Hrubis
2026-07-10 11:55 ` linuxtestproject.agent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710115521.3898-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox