Re: [LTP] [PATCH] fanotify25: Add CVE reference and include it in CVE runfile

[Petr Vorel <pvorel@suse.cz>]

Hi Martin,

> The kernel bug tested by fanotify25 is assigned CVE 2023-52879. Add
> CVE reference and git reference for the kernel fix. Also add the test
> to the CVE runfile.

Thanks, merged!

...
>  /*\
> + * CVE-2023-52879
> + *
>   * Verify that :manpage:`fanotify(7)` monitoring can be applied to the tracing
> - * filesystem and write events will be correctly delivered.
> + * filesystem and write events will be correctly delivered. NULL pointer
> + * dereference fixed in:
> + *
> + * commit bb32500fb9b78215e4ef6ee8b4345c5f5d7eafb4
> + * Author: Steven Rostedt (Google) <rostedt@goodmis.org>
> + * Date:   Tue Oct 31 12:24:53 2023 -0400
> + *
> + * tracing: Have trace_event_file have ref counters

Using this form in /*\ results in ugly inline string in the test catalog:
commit bb32500fb9b78215e4ef6ee8b4345c5f5d7eafb4 Author: Steven Rostedt (Google) <rostedt@goodmis.org> Date: Tue Oct 31 12:24:53 2023 -0400


I dared to convert this to inline + add kernel version.

...
+ * dereference fixed in kernel 6.7:
+ * bb32500fb9b7 ("tracing: Have trace_event_file have ref counters")

If we really see a benefit of having author and date in the docs, it'd be better
to have it in C comments /* */ which aren't generated in the test catalog. Or,
we could shift it so that it is preformatted (<pre>...</pre>). Or we could use
sphinx automarkup extension to detect this form and format it as is (not inline)
+ use link.

...
> @@ -118,6 +127,11 @@ static struct tst_test test = {
>  	.needs_kconfigs = (const char *[]) {
>  		"CONFIG_TRACING",
>  		NULL
> +	},
> +	.tags = (const struct tst_tag[]) {
> +		{"linux-git", "bb32500fb9b7"},
And I should have changed the hash to the longer one:
bb32500fb9b78215e4ef6ee8b4345c5f5d7eafb4

FYI we have decided keep in the description the long the short variant (with
strlen) to minimize possibility of git hash collision.  I plan to convert all
with script/agent.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp