Linux Test Project
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] syscall02: test invalid syscall number -1
Date: Tue, 14 Jul 2026 10:50:11 +0000	[thread overview]
Message-ID: <20260714105011.4039-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260714-syscall_invalid_nr-v1-1-d8b6f4e3ec7b@suse.com>

Hi Andrea,

On Tue, 14 Jul 2026 11:25:40 +0200, Andrea Cervesato wrote:
> syscall02: test invalid syscall number -1

> +#include <unistd.h>
> +#include <sys/syscall.h>

<sys/syscall.h> provides SYS_* constants, but none are used here.
syscall() is declared by <unistd.h>. The include can be dropped.

> + * Verify that a raw :manpage:`syscall(2)` with the reserved system call
> + * number -1 fails with ENOSYS.

Same in the commit message body: -1 is not formally reserved by the
kernel ABI or POSIX. It is simply an out-of-range number that lands on
sys_ni_syscall. The test itself uses "invalid" in the message string,
which is the more accurate term. Worth aligning the description with
that wording.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-07-14 10:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14  9:25 [LTP] [PATCH] syscall02: test invalid syscall number -1 Andrea Cervesato
2026-07-14 10:50 ` linuxtestproject.agent [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-07-14 10:56 [LTP] [PATCH v2] " Andrea Cervesato
2026-07-14 12:18 ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260714105011.4039-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox