Re: [LTP] lapi: Add pkt_cls.h fallback

[linuxtestproject.agent@gmail.com]

Hi Andrea,

On Tue, 14 Jul 2026 10:38:58 +0200, Andrea Cervesato wrote:
> lapi: Add pkt_cls.h fallback

--- [PATCH 4/4] ---

> +/*
> + * Same as NETDEV_REMOVE_QDISC() but does not fail when the qdisc is
> + * missing (strict=0), so it can be used to clear a possibly absent qdisc.
> + */
> +#define NETDEV_MAY_REMOVE_QDISC(ifname, family, parent, handle, qd_kind) \

New public macros in include/ require kernel-doc (/** */), not a plain
block comment. The content is fine; it just needs the right opener:

  /**
   * NETDEV_MAY_REMOVE_QDISC - remove qdisc without failing if absent.
   * @ifname: network interface name
   * @family: address family
   * @parent: parent handle
   * @handle: qdisc handle
   * @qd_kind: qdisc kind string
   *
   * Same as NETDEV_REMOVE_QDISC() but passes strict=0, so it does not
   * fail when the qdisc is missing.
   */

> +#define NETDEV_REMOVE_QDISC(ifname, family, parent, handle, qd_kind) \
>  	tst_netdev_remove_qdisc(__FILE__, __LINE__, 1, (ifname), (family), \
>  		(parent), (handle), (qd_kind))
> +/*

No blank line between the closing of NETDEV_REMOVE_QDISC and the comment
that opens NETDEV_MAY_REMOVE_QDISC. All other macro blocks in the file
have a blank line between them.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp