Re: [LTP] LTP/Lite test float_trigo core dumps due to free(): invalid pointer

[linuxtestproject.agent@gmail.com]

Hi Tomas,

On Wed, 15 Jul 2026, Tomas Dzik wrote:
> LTP/Lite test float_trigo core dumps due to free(): invalid pointer

--- [PATCH 1/3] ---

> Function read_file() does not initialize *data on failure paths
> (for example if malloc() fails) and caller ens up calling SAFE_FREE()
> on an uninitialized pointer.

Typo: "caller ens up" should be "caller ends up".

> +	/*
> +	 * If read_file() fails for whatever reason, these pointers might
> +	 * stay uninitialized. Initialize them to NULL, because SAFE_FREE()
> +	 * can handle it.
> +	 */
> +
> +	double *din = NULL, *dex = NULL, *dex2 = NULL;

There is a blank line between the comment and the declaration it
describes. A block comment that annotates the immediately following
statement should have no empty line between them.

--- [PATCH 2/3] ---

> Because it was contributing factor to observed core dump I am adding
> these checks to make debugging failures easier.

Grammar: "it was contributing factor" should be "it was a contributing
factor".

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp