Re: [LTP] futex_wake05: Add EFAULT error coverage test

[linuxtestproject.agent@gmail.com]

Hi Michael,

On Thu, 16 Jul 2026 16:31:07 +0300, Michael Menasherov <mmenashe@redhat.com> wrote:
> futex_wake05: Add EFAULT error coverage test

--- [PATCH 1/2] ---

> +/*\
> + * Check that futex(FUTEX_WAKE) returns EFAULT when uaddr points to

The doc block is rendered in the test catalog as reStructuredText. When
referring to a raw syscall in a /*\ ... */ block, the :manpage: role is
required (c-tests.md rule 19). Should this read:

  Check that :manpage:`futex(2)` with ``FUTEX_WAKE`` returns EFAULT
  when uaddr points to ...

--- [PATCH 2/2] ---

> +/*\
> + * Check that futex(FUTEX_CMP_REQUEUE) returns EFAULT when uaddr or

Same :manpage: issue: "futex(FUTEX_CMP_REQUEUE)" should be
":manpage:`futex(2)`" with "``FUTEX_CMP_REQUEUE``" for the operation.

> +/futex_cmp_requeue03

The git.md rule requires .gitignore entries to be kept sorted. The
existing file already has /futex_cmp_requeue01 and /futex_cmp_requeue02
near the top. Appending /futex_cmp_requeue03 at the end leaves it out
of order; it belongs immediately after /futex_cmp_requeue02.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp