Re: [LTP] lib: New library function tst_get_free_uid

[linuxtestproject.agent@gmail.com]

Hi Wei,

On Tue, 21 Jul 2026 07:41:28 +0000, Wei Gao wrote:
> lib: New library function tst_get_free_uid

--- [PATCH 1/2] ---

> -		tst_res_(file, lineno, TINFO | TERRNO,
> +		tst_res_(file, lineno, TINFO,
>  			"Found unused GID %d", (int)ret);

This hunk is a fix to the existing tst_get_free_gid_() success path --
removing | TERRNO so errno is not printed when a free GID is found.

That is a reasonable fix on its own, but it has no relationship to the
new tst_get_free_uid() API that the commit message describes. The commit
message does not mention it.

Could these be split into two patches?

  1/3  lib/tst_uid: Remove spurious TERRNO from tst_get_free_gid success path
  2/3  lib: New library function tst_get_free_uid
  3/3  open16: allow restricted O_CREAT of FIFOs and regular files

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp