Linux Test Project
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Pavithra <pavrampu@linux.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] hugemmap/hugemmap41: Migrate ptrace-write-hugepage from libhugetlbfs
Date: Sun,  9 Aug 2026 17:33:21 +0000	[thread overview]
Message-ID: <20260809173321.8905-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260809171646.1832676-1-pavrampu@linux.ibm.com>

Hi Pavithra,

On Sun, 9 Aug 2026, Pavithra wrote:
> hugemmap/hugemmap41: Migrate ptrace-write-hugepage from libhugetlbfs

> +	tst_res(TINFO, "Poking at %p...", p);
> +	SAFE_PTRACE(PTRACE_POKEDATA, pid, p, (void *)CONST);

Could this call use TEST() or a suitable TST_EXP_* check and report failure
as TFAIL? PTRACE_POKEDATA is an operation under test, but SAFE_PTRACE()
converts a kernel regression here into TBROK.

> +/hugetlb/hugemmap/hugemmap41

Could this entry instead be added as /hugemmap41 in
testcases/kernel/mem/hugetlb/hugemmap/.gitignore? LTP keeps generated test
binary entries in the leaf test directory so they move or disappear with
that directory.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-08-09 17:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-09 17:16 [LTP] [PATCH] hugemmap/hugemmap41: Migrate ptrace-write-hugepage from libhugetlbfs Pavithra
2026-08-09 17:33 ` linuxtestproject.agent [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-08-09 18:50 [LTP] [PATCH v8] " Pavithra
2026-08-09 19:37 ` [LTP] " linuxtestproject.agent
2026-08-08 17:02 [LTP] [PATCH v6] " Pavithra
2026-08-08 17:33 ` [LTP] " linuxtestproject.agent
2026-08-08 15:02 [LTP] [PATCH v5] " Pavithra
2026-08-08 15:30 ` [LTP] " linuxtestproject.agent
2026-07-17 18:05 [LTP] [PATCH] " Pavithra
2026-07-17 19:13 ` [LTP] " linuxtestproject.agent
2026-08-04 12:25   ` Cyril Hrubis
2026-08-04 12:28     ` Andrea Cervesato via ltp
2026-07-17 11:02 [LTP] [PATCH] " Pavithra
2026-07-17 11:28 ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260809173321.8905-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=pavrampu@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox