Re: [LTP] testcases/kernel/crypto/crypto_user02.c: try non-generic hmac names first

[linuxtestproject.agent@gmail.com]

Hi Frank,

On Wed, 12 Aug 2026, Frank Ranner wrote:
> testcases/kernel/crypto/crypto_user02.c: try non-generic hmac names first

> +	"hmac(sha1)",
> +	"hmac(sha224)",
> +	"hmac(sha256)",
> +	"hmac(sha384)",
> +	"hmac(md5)",
> +	"hmac(sm3)",
> +	"hmac(sha512)",
> +	"hmac(rmd160)",
> +	"hmac(sha3-224)",
> +	"hmac(sha3-256)",
> +	"hmac(sha3-384)",
> +	"hmac(sha3-512)",
> +	"hmac(streebog256)",
> +	"hmac(streebog512)",

[Major] Could these be replaced with actual deletable instance driver names?
The strings are copied into cru_driver_name, but these new values are
algorithm names.

On Linux 7.2, CRYPTO_MSG_NEWALG first misses the exact driver-name lookup
for "hmac(sha256)", then finds the non-instance "hmac-sha256-lib" driver by
its cra_name and returns success. CRYPTO_MSG_DELALG subsequently requires an
exact driver-name match, cannot find "hmac(sha256)", and returns ENOENT.

Consequently, the setup loop rejects every newly added candidate and still
reaches TCONF when the legacy *-generic instances are absent. The 7.2 HMAC
shash template instead produces deletable hmac-shash(<driver>) instance
names.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp