Re: [LTP] [PATCH v5 3/7] lib: Add support for max_kver to struct tst_test and tst_fs

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > I deliberately did not add it and documented my intention in
> > doc/developers/writing_tests.rst LTP C And Shell Test API Comparison table
> > +    * - .max_kver
> > +      - not implemented

> This is correct since this is different shell API (v2). The change I
> requested is newest shell API (v3).

Unfortunately we have many tests in v2, I hoped we would at lest mention there
is v2. I'm not happy with the fact that we document only v3, IMHO at least have
link v2 API is in doc/old/Shell-.... would be good.

> This is also reason why I asked for deletion of this table, it
> documments older API (tst_test.sh) and confuses people.

BTW the test was moved there in 4a72aada873, which was 4 months ago before you
wrote shell loader API (5528da0231).

I still think it's useful (until we rewrite more tests into shell API => now we
have many tests for which we delete documentation), but it should be clearly
visible it's for tst_test.sh (v2 API). But I'm ok to remove it if you don't want
to waste time with v2 (we removed part of old docs in 4a72aada873 which removed
also doc/old/Test-Writing-Guidelines.asciidoc which had this table).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp