Linux Test Project
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Pavithra <pavrampu@linux.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] memcg/memcontrol05: add cgroup v2 task migration charge accounting test
Date: Thu, 13 Aug 2026 17:09:42 +0000	[thread overview]
Message-ID: <20260813170942.4217-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260813162337.3012813-1-pavrampu@linux.ibm.com>

Hi Pavithra,

On Thu, Aug 13, 2026, Pavithra wrote:
> memcg/memcontrol05: add cgroup v2 task migration charge accounting test

> 	group_a = tst_cg_group_mk(tst_cg, "group_a");
> 	group_b = tst_cg_group_mk(tst_cg, "group_b");
>
> 	SAFE_CG_SCANF(group_b, "memory.current", "%ld", &baseline_b);

Could the test disable swapping for both child cgroups before starting the
worker? Touching the pages only makes them resident at that instant. Under
memory pressure, group_a pages can be swapped between the checkpoint and
the reads, so memory.current drops while the charge remains correctly
associated with group_a in memory.swap.current. The same race affects the
group_b delta after the second allocation and can produce a false failure.

Setting memory.swap.max to 0, or otherwise keeping the pages resident, would
make the memory.current assertions measure migration accounting reliably.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-08-13 17:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 16:23 [LTP] [PATCH v3] memcg/memcontrol05: add cgroup v2 task migration charge accounting test Pavithra
2026-08-13 17:09 ` linuxtestproject.agent [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-08-13 19:54 [LTP] [PATCH v5] " Pavithra
2026-08-13 20:44 ` [LTP] " linuxtestproject.agent
2026-08-13 18:42 [LTP] [PATCH v4] " Pavithra
2026-08-13 19:06 ` [LTP] " linuxtestproject.agent
2026-08-12 16:16 [LTP] [PATCH v2] " Pavithra
2026-08-12 17:07 ` [LTP] " linuxtestproject.agent
2026-08-04  9:59 [LTP] [PATCH] " Pavithra
2026-08-04 10:41 ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260813170942.4217-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=pavrampu@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox