Re: [LTP] syscalls: rename11: Convert test to new API

[linuxtestproject.agent@gmail.com]

Hi Avinesh,

On Thu, Aug 13, 2026, Avinesh Kumar wrote:
> syscalls: rename11: Convert test to new API

> syscalls: rename11: Convert test to new API
>
> Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>

Could the commit message include a sentence explaining why this conversion is
needed? This changes lifecycle, device handling, result reporting, and cleanup
semantics, so it is not a trivial change for which the subject alone explains
the motivation.

> +/*\
> + * Verify that :manpage:`rename(2)` fails with:
> + *
> + * - ``ELOOP`` when too many symbolic links are encountered while resolving
> + *   oldpath or newpath.
> + * - ``EROFS`` when the file is on a read-only file system.
> + * - ``EMLINK`` when oldpath is a directory and the link count of the parent
> + *   directory of newpath would exceed ``LINK_MAX``.
> + */

Could the description state that root is required to mount and remount the
test filesystem for the EROFS case? Tests setting ``.needs_root`` must
document why those privileges are needed.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp