Linux Test Project
 help / color / mirror / Atom feed
From: Andrea Cervesato <andrea.cervesato@suse.de>
To: Linux Test Project <ltp@lists.linux.it>
Subject: [LTP] [PATCH STAGING 10/16] fchroot07: test execve blocked by failfs root
Date: Wed, 19 Aug 2026 23:24:25 +0200	[thread overview]
Message-ID: <20260819-fchroot-v1-10-2dc2c3c3cf29@suse.com> (raw)
In-Reply-To: <20260819-fchroot-v1-0-2dc2c3c3cf29@suse.com>

From: Andrea Cervesato <andrea.cervesato@suse.com>

Verify that after fchroot() moved the root into failfs, loading a
binary by absolute path fails with EOPNOTSUPP. The exec runs in a
grandchild so a wrongly successful exec is still detected through
the exit code.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 runtest/staging                               |  1 +
 testcases/kernel/syscalls/fchroot/.gitignore  |  1 +
 testcases/kernel/syscalls/fchroot/fchroot07.c | 71 +++++++++++++++++++++++++++
 3 files changed, 73 insertions(+)

diff --git a/runtest/staging b/runtest/staging
index 8b6b1ecd9..b8954bb5a 100644
--- a/runtest/staging
+++ b/runtest/staging
@@ -6,3 +6,4 @@ fchroot03 fchroot03
 fchroot04 fchroot04
 fchroot05 fchroot05
 fchroot06 fchroot06
+fchroot07 fchroot07
diff --git a/testcases/kernel/syscalls/fchroot/.gitignore b/testcases/kernel/syscalls/fchroot/.gitignore
index 12151270a..b68069d9a 100644
--- a/testcases/kernel/syscalls/fchroot/.gitignore
+++ b/testcases/kernel/syscalls/fchroot/.gitignore
@@ -4,3 +4,4 @@ fchroot03
 fchroot04
 fchroot05
 fchroot06
+fchroot07
diff --git a/testcases/kernel/syscalls/fchroot/fchroot07.c b/testcases/kernel/syscalls/fchroot/fchroot07.c
new file mode 100644
index 000000000..d7b5d159b
--- /dev/null
+++ b/testcases/kernel/syscalls/fchroot/fchroot07.c
@@ -0,0 +1,71 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2026 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
+ */
+
+/*\
+ * Test that :manpage:`execve(2)` is blocked under the failfs root.
+ *
+ * After :manpage:`fchroot(2)` moved the process root into failfs, loading
+ * a binary by absolute path fails with EOPNOTSUPP.
+ *
+ * Root is required because entering failfs with the FD_FAILFS_ROOT
+ * sentinel requires CAP_SYS_CHROOT.
+ *
+ * The exec runs in a grandchild: a wrongly successful exec would replace
+ * the test image, so the outcome can only be reported when the exec call
+ * returns, and the grandchild exit code tells the parent whether the
+ * image was replaced.
+ */
+
+#define _GNU_SOURCE
+#include <sys/wait.h>
+#include <unistd.h>
+#include "tst_test.h"
+#include "lapi/fcntl.h"
+#include "lapi/syscalls.h"
+
+/* Marker exit code proving the grandchild image was not replaced. */
+#define EXEC_NOT_REPLACED 42
+
+static void check_exec_blocked(void)
+{
+	pid_t pid = SAFE_FORK();
+	int status;
+
+	if (!pid) {
+		TST_EXP_FAIL(execl("/bin/true", "true", NULL), EOPNOTSUPP,
+			"absolute exec blocked by the failfs root");
+
+		exit(EXEC_NOT_REPLACED);
+	}
+
+	SAFE_WAITPID(pid, &status, 0);
+	if (!WIFEXITED(status) || WEXITSTATUS(status) != EXEC_NOT_REPLACED)
+		tst_res(TFAIL, "exec replaced the test image");
+}
+
+static void run(void)
+{
+	if (!SAFE_FORK()) {
+		TST_EXP_PASS(tst_syscall(__NR_fchroot, FD_FAILFS_ROOT, 0),
+			"fchroot() with the FD_FAILFS_ROOT sentinel");
+
+		check_exec_blocked();
+
+		exit(0);
+	}
+}
+
+static void setup(void)
+{
+	if (access("/bin/true", X_OK))
+		tst_brk(TCONF | TERRNO, "/bin/true is not available");
+}
+
+static struct tst_test test = {
+	.setup = setup,
+	.test_all = run,
+	.needs_root = 1,
+	.forks_child = 1,
+};

-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-08-19 21:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 21:24 [LTP] [PATCH 00/16] fchroot: add fchroot() testing suite Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH 01/16] syscalls: add v7.3 syscall numbers Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH 02/16] syscalls: update outdated syscall entries Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH 03/16] lapi: fallback fchroot() parameters Andrea Cervesato
2026-08-19 22:27   ` [LTP] syscalls: add v7.3 syscall numbers linuxtestproject.agent
2026-08-20  6:03     ` Andrea Cervesato via ltp
2026-08-19 21:24 ` [LTP] [PATCH STAGING 04/16] fchroot01: test fchroot() with a directory fd Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 05/16] fchroot02: test fchroot() invalid arguments Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 06/16] fchroot03: test fchroot() permission checks Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 07/16] fchroot04: test fchroot() into failfs as root Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 08/16] fchroot05: test failfs root can not be referenced Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 09/16] fchroot06: test path walks under failfs root Andrea Cervesato
2026-08-19 21:24 ` Andrea Cervesato [this message]
2026-08-19 21:24 ` [LTP] [PATCH STAGING 11/16] fchroot08: test failfs root fork inheritance Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 12/16] fchroot09: test setns escape from failfs root Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 13/16] fchroot10: test failfs entry without no_new_privs Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 14/16] fchroot11: test failfs entry with no_new_privs Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 15/16] fchroot12: test failfs entry with shared fs_struct Andrea Cervesato
2026-08-19 21:24 ` [LTP] [PATCH STAGING 16/16] fchroot13: test failfs entry when chrooted Andrea Cervesato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819-fchroot-v1-10-2dc2c3c3cf29@suse.com \
    --to=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox