From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 738E1C5DF81 for ; Thu, 20 Aug 2026 07:48:46 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 1DCAF3C0224 for ; Thu, 20 Aug 2026 09:48:45 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 29EC73CE89A for ; Thu, 20 Aug 2026 09:45:03 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 587C31A00346 for ; Thu, 20 Aug 2026 09:45:02 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D81BC3EEC; Thu, 20 Aug 2026 07:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787211897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RKxINB/hl7cqIAldi3hoXagFeTt0F1/2xafi1OP+IA8=; b=ljf2LxEH5sw9WmQTKzsjSP7dWGC1ZJ6fwxDVRHoHtrH4MElryMN40Rv0eQjavFJc4uW45b 4rkYaxMxiyGnHur+wJByMkeSFw2nvkWYSimVhT05AlV69qj1LOue9ElfrcrKbMpv7ox/PM o5nUnevDRaNeqXVt9ldeLyx9p2yrAGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787211897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RKxINB/hl7cqIAldi3hoXagFeTt0F1/2xafi1OP+IA8=; b=jkF3aBAq/dP+7Igpmi1UIY3BNoMHUu/rUiiD1pWqGAaDs9+zX+ZtfzNGq5w3vn1mIGvzxS EGzyc49pQLy5pyDg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=nKqIS+0I; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=GYuOAiG7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787211892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RKxINB/hl7cqIAldi3hoXagFeTt0F1/2xafi1OP+IA8=; b=nKqIS+0IPWJxAhapcURr2MrYc9IxLa4On9khzepTSBHQRqhpfrEHzbNjRGFhLocVhtxw8U zghSVsYjDThF6x9ovtwJZ9jYQ01cxFLmGWHAlCz35DMJOhGSTwNAn3aeWk/V4GnwzGOSy0 cHdIcHyk18X4+wCDf1V1JLuJMSI0rzc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787211892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RKxINB/hl7cqIAldi3hoXagFeTt0F1/2xafi1OP+IA8=; b=GYuOAiG7JAGx5HfnySm0MMCTQ14RNYetgbwxhWTM2h2fssRrif1HwmgckLLgN63RiGEVPq CNqK9dv2KG6dXuAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 15E3D3681; Thu, 20 Aug 2026 07:44:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aAM9Am6whmr3YgAAD6G6ig (envelope-from ); Thu, 20 Aug 2026 07:44:46 +0000 From: Andrea Cervesato Date: Thu, 20 Aug 2026 09:44:49 +0200 MIME-Version: 1.0 Message-Id: <20260820-fchroot-v2-9-062ed20957a0@suse.com> References: <20260820-fchroot-v2-0-062ed20957a0@suse.com> In-Reply-To: <20260820-fchroot-v2-0-062ed20957a0@suse.com> To: Linux Test Project X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787211883; l=4535; i=andrea.cervesato@suse.com; s=20251210; h=from:subject:message-id; bh=pyeKjGE/EISWXa4T5SkkCkOlkT5jV3gj2nHq2HIWrII=; b=N66q8kf4000jHjNDBvEsfBoXyxWNkjP0VMGa8lASKDa7+FCLzOfRv3yTSPg7stxaVFcADBWLB HfOvsXykoj4CLYtVCJ9s6yG38IMqpso/tF/HgIBXBqJjUEpbsxaCK+b X-Developer-Key: i=andrea.cervesato@suse.com; a=ed25519; pk=zKY+6GCauOiuHNZ//d8PQ/UL4jFCTKbXrzXAOQSLevI= X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.com:mid,suse.com:email]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: D81BC3EEC X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH STAGING v2 09/16] fchroot06: test path walks under failfs root X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" From: Andrea Cervesato Verify that once the root is in failfs only lookups anchored at a file descriptor keep working: relative lookups from the working directory and from a pre-opened directory fd succeed, absolute symlinks fail with EOPNOTSUPP and ".." walks clamp at the top of the mount tree, landing on the real root. Signed-off-by: Andrea Cervesato --- runtest/staging | 1 + testcases/kernel/syscalls/fchroot/.gitignore | 1 + testcases/kernel/syscalls/fchroot/fchroot06.c | 117 ++++++++++++++++++++++++++ 3 files changed, 119 insertions(+) diff --git a/runtest/staging b/runtest/staging index 49f51d637..8b6b1ecd9 100644 --- a/runtest/staging +++ b/runtest/staging @@ -5,3 +5,4 @@ fchroot02 fchroot02 fchroot03 fchroot03 fchroot04 fchroot04 fchroot05 fchroot05 +fchroot06 fchroot06 diff --git a/testcases/kernel/syscalls/fchroot/.gitignore b/testcases/kernel/syscalls/fchroot/.gitignore index 0697f10eb..12151270a 100644 --- a/testcases/kernel/syscalls/fchroot/.gitignore +++ b/testcases/kernel/syscalls/fchroot/.gitignore @@ -3,3 +3,4 @@ fchroot02 fchroot03 fchroot04 fchroot05 +fchroot06 diff --git a/testcases/kernel/syscalls/fchroot/fchroot06.c b/testcases/kernel/syscalls/fchroot/fchroot06.c new file mode 100644 index 000000000..bf6c4fea4 --- /dev/null +++ b/testcases/kernel/syscalls/fchroot/fchroot06.c @@ -0,0 +1,117 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (C) 2026 SUSE LLC Andrea Cervesato + */ + +/*\ + * Test path walks under the failfs root. + * + * Once :manpage:`fchroot(2)` moved the process root into failfs, only + * lookups anchored at a file descriptor keep working: + * + * - lookups relative to the working directory, which stays in the real + * filesystem, keep working + * - lookups anchored at a pre-opened directory fd keep working, including + * resolution of relative symlinks + * - absolute symlinks restart the walk at the failfs root and fail with + * ``EOPNOTSUPP`` + * - ".." walks clamp at the top of the mount tree, not at the failfs + * root, so walking up from the working directory lands on the real + * root + * + * Root is required because entering failfs with the ``FD_FAILFS_ROOT`` + * sentinel requires ``CAP_SYS_CHROOT``. + * + * The test runs in a forked child so the root of the parent process is + * left untouched. + */ + +#define _GNU_SOURCE +#include +#include +#include "tst_test.h" +#include "lapi/fcntl.h" +#include "lapi/syscalls.h" +#include "tst_safe_file_at.h" + +#define RELDIR "rel" +#define ABSDIR "abs" + +static char upwards[PATH_MAX]; + +static void run(void) +{ + if (SAFE_FORK()) + return; + + struct stat realroot, st; + int dfd, fd; + + SAFE_STAT("/", &realroot); + dfd = SAFE_OPEN(".", O_RDONLY | O_DIRECTORY); + + TST_EXP_PASS(tst_syscall(__NR_fchroot, FD_FAILFS_ROOT, 0), + "fchroot() with the FD_FAILFS_ROOT sentinel"); + + fd = SAFE_OPENAT(AT_FDCWD, ".", O_RDONLY | O_DIRECTORY); + SAFE_CLOSE(fd); + + fd = SAFE_OPENAT(dfd, "canary", O_WRONLY | O_CREAT, 0600); + SAFE_WRITE(SAFE_WRITE_ALL, fd, "x", 1); + SAFE_CLOSE(fd); + + fd = SAFE_OPENAT(dfd, RELDIR, O_RDONLY); + SAFE_CLOSE(fd); + + TST_EXP_FAIL2(openat(dfd, ABSDIR, O_RDONLY), EOPNOTSUPP, + "resolution of an absolute symlink"); + + fd = SAFE_OPENAT(AT_FDCWD, upwards, O_PATH); + SAFE_FSTAT(fd, &st); + SAFE_CLOSE(fd); + + TST_EXP_EXPR(st.st_dev == realroot.st_dev && + st.st_ino == realroot.st_ino, + "'..' walk clamps at the top of the mount tree"); + + SAFE_CLOSE(dfd); + + exit(0); +} + +static void setup(void) +{ + char *tmpdir; + char abs_path[PATH_MAX]; + struct stat root_st, st; + int fd, off; + + tmpdir = tst_tmpdir_path(); + snprintf(abs_path, sizeof(abs_path), "%s/%s", tmpdir, "target"); + + SAFE_TOUCH("target", 0644, NULL); + SAFE_SYMLINK("target", RELDIR); + SAFE_SYMLINK(abs_path, ABSDIR); + + SAFE_STAT("/", &root_st); + + off = snprintf(upwards, sizeof(upwards), ".."); + while (1) { + fd = SAFE_OPENAT(AT_FDCWD, upwards, O_PATH); + SAFE_FSTAT(fd, &st); + SAFE_CLOSE(fd); + + if (st.st_dev == root_st.st_dev && st.st_ino == root_st.st_ino) + break; + + off += snprintf(upwards + off, sizeof(upwards) - off, "/.."); + } +} + +static struct tst_test test = { + .setup = setup, + .test_all = run, + .needs_root = 1, + .needs_tmpdir = 1, + .forks_child = 1, +}; -- 2.51.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp