From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85F2BC5DF81 for ; Thu, 20 Aug 2026 15:58:18 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id E420A3CE682 for ; Thu, 20 Aug 2026 17:58:16 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id D89F33C5DED for ; Thu, 20 Aug 2026 17:58:01 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 479471A00782 for ; Thu, 20 Aug 2026 17:58:00 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8CAE63EEB; Thu, 20 Aug 2026 15:58:00 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2E50727A8; Thu, 20 Aug 2026 15:58:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id F7eQBggkh2rJRgAAD6G6ig (envelope-from ); Thu, 20 Aug 2026 15:58:00 +0000 Date: Thu, 20 Aug 2026 17:57:57 +0200 From: Petr Vorel To: Cyril Hrubis Message-ID: <20260820155757.GB495062@pevik> References: <20260819161634.1341577-1-chrubis@suse.cz> <20260819161634.1341577-13-chrubis@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260819161634.1341577-13-chrubis@suse.cz> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 8CAE63EEB X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 12/31] testcases: sysfs: Add sys_ata01 X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Cyril, > A test for /sys/class/ata_device/*/* files. Lol, on one of my system I don't have /sys/class/ata_device/, but I have /sys/class/scsi_device/ directory. I suppose SCSI is still used but obsolete right? Or would it be worth to test it as well? ... > +++ b/testcases/kernel/sysfs/class/ata_device/sys_ata01.c > @@ -0,0 +1,96 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Copyright (c) 2026 Cyril Hrubis > + */ > + > +/*\ > + * Sanity checks for the ATA device attributes exported under > + * /sys/class/ata_device//. > + * > + * For every ATA device the test verifies that: > + * > + * - class is one of the known libata device classes (ata, atapi, pmp, semb, > + * unknown) > + * - dma_mode, pio_mode and xfer_mode, when non-empty, start with the "XFER_" Please, before merge change to: - * - dma_mode, pio_mode and xfer_mode, when non-empty, start with the "XFER_" + * - dma_mode, pio_mode and xfer_mode, when non-empty, start with the ``XFER_`` otherwise sphinx complains: _static/tests.rst:45958: ERROR: Unknown target name: "xfer". [docutils] Otherwise LGTM, nice test, great patchset. Only to this particular patch: Reviewed-by: Petr Vorel I try to have look on the whole patchset tomorrow. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp