Re: [LTP] [PATCH v1 1/1] swap: Add exfat to filesystems requiring tst_fill_file

[Petr Vorel <pvorel@suse.cz>]

> On Thu, Jul 02, 2026 at 10:10:09AM +0000, Andrea Cervesato wrote:
> > Hi Jan,

> > I seen you implemented in v7.2-rc1:

> > commit 03a43677ca91e3997355a13b1da6e47329b025e1
> > Author: Jan Polensky <japo@linux.ibm.com>
> > Date:   Tue Jun 9 18:21:49 2026 +0900

> >     exfat: add swap_activate support

> >     Commit 07d67f3e9083 ("exfat: add iomap buffered I/O support")
> >     converted exfat buffered I/O to iomap, but did not add a
> >     .swap_activate handler to the address_space_operations.

> >     swapon(2) on an exfat swapfile then fails with EINVAL, which causes
> >     LTP swap tests to fail.

> >     Add exfat_iomap_swap_activate() and hook it into exfat_aops so exfat
> >     uses iomap_swapfile_activate() for swapfile activation.

> >     Fixes: 614f71ca1bdf ("exfat: add iomap buffered I/O support")
> >     Closes: https://lore.kernel.org/all/20260603110212.3020276-1-japo@linux.ibm.com/
> >     Signed-off-by: Jan Polensky <japo@linux.ibm.com>
> >     Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>

> > what should we do with your patch in LTP?

> > Regards,
> > --
> > Andrea Cervesato
> > SUSE QE Automation Engineer Linux
> > andrea.cervesato@suse.com

> Hi Andrea,

> Thanks for following up on this.

> On my side (s390x, Fedora 44, kernel v7.2-rc1), I still need both
> patches for the LTP swap tests to pass:
>  1. The kernel fix (03a43677ca91 "exfat: add swap_activate support")
>  2. This LTP patch (adding exfat to tst_fill_file)

> Without the LTP patch, the tests still fail even with the kernel fix
> applied.

> Could you validate on your setup whether the kernel fix alone is
> sufficient, or if you also need this LTP patch? It would be good to
> understand if this is architecture-specific or a general requirement.

> If you can confirm the tests pass with only the kernel fix, we can
> close this LTP patch. Otherwise, one should merge it.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

And yeah, we need it in kernel 7.2 on any distro :).

Should we somehow mention relevant kernel commit at least in the commit message?

e.g.: Change needed since 03a43677ca91 ("exfat: add swap_activate support") from
v7.2-rc1.

Kind regards,
Petr

> Best regards,
> Jan

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp