From: linuxtestproject.agent@gmail.com
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] lapi/mmap: add MAP_32BIT fallback
Date: Fri, 28 Aug 2026 21:10:38 +0000 [thread overview]
Message-ID: <20260828211038.8829-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260828-mmap_32bit_coverage-v1-1-7f0b8b589773@suse.com>
Hi Andrea,
On Aug 28, 2026, Andrea Cervesato wrote:
> lapi/mmap: add MAP_32BIT fallback
--- [PATCH 3/3] ---
> * - Verify that memory in each chunk is readable and writable
> [...]
> ((char *)addr)[0] = 'a';
> ((char *)addr)[CHUNK_SZ - 1] = 'z';
The algorithm says that each chunk is verified to be both readable and
writable, but these statements only write to the mapping. Could the test
read and compare the stored bytes, or should the readability claim be
removed?
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-08-28 21:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 15:36 [LTP] [PATCH 0/3] mmap testing suite to cover MAP_32BIT Andrea Cervesato
2026-08-28 15:36 ` [LTP] [PATCH 1/3] lapi/mmap: add MAP_32BIT fallback Andrea Cervesato
2026-08-28 21:10 ` linuxtestproject.agent [this message]
2026-08-31 8:02 ` [LTP] " Andrea Cervesato via ltp
2026-09-11 13:20 ` [LTP] [PATCH 1/3] " Petr Vorel
2026-09-11 13:26 ` Petr Vorel
2026-08-28 15:36 ` [LTP] [PATCH 2/3] mmap23: add test for MAP_32BIT oversized mapping Andrea Cervesato
2026-09-11 14:08 ` Petr Vorel
2026-08-28 15:36 ` [LTP] [PATCH 3/3] mmap24: add test for MAP_32BIT address limit Andrea Cervesato
2026-09-10 14:38 ` Cyril Hrubis
2026-09-11 13:59 ` Petr Vorel
2026-09-11 15:16 ` Andrea Cervesato via ltp
2026-09-11 16:03 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2026-09-11 15:29 [LTP] [PATCH v3 1/3] lapi/mmap: add MAP_32BIT fallback Andrea Cervesato
2026-09-11 17:42 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828211038.8829-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox