From: linuxtestproject.agent@gmail.com
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] lib: Extend tst_assert_ulong() with enum flags
Date: Thu, 3 Sep 2026 12:00:38 +0000 [thread overview]
Message-ID: <20260903120038.8629-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260903095255.4925-2-wegao@suse.com>
Hi Wei,
On Sep 3, 2026, Wei Gao wrote:
> lib: Extend tst_assert_ulong() with enum flags
--- [PATCH 1/2] ---
> +#define TST_ASSERT_ULONG(path, val, ...) \
> + tst_assert_ulong(__FILE__, __LINE__, path, val, \
> + TST_2_(dummy, ##__VA_ARGS__, 0))
TST_ASSERT_ULONG is a modified public macro but lacks the required
kernel-doc comment. Please document its optional flags argument and the
zero-flags default at the macro itself.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-09-03 12:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 9:52 [LTP] [PATCH v11 0/2] shmctl03: Fix 32-bit compat mode failure Wei Gao via ltp
2026-09-03 9:52 ` [LTP] [PATCH v11 1/2] lib: Extend tst_assert_ulong() with enum flags Wei Gao via ltp
2026-09-03 12:00 ` linuxtestproject.agent [this message]
2026-09-04 8:51 ` Andrea Cervesato via ltp
2026-09-07 7:29 ` Wei Gao via ltp
2026-09-03 9:52 ` [LTP] [PATCH v11 2/2] shmctl03: Fix 32-bit compat mode failure Wei Gao via ltp
-- strict thread matches above, loose matches on Subject: below --
2026-09-03 3:32 [LTP] [PATCH v10 1/2] lib: Extend tst_assert_ulong() with enum flags Wei Gao via ltp
2026-09-03 6:57 ` [LTP] " linuxtestproject.agent
2026-08-31 8:16 [LTP] [PATCH v9 1/2] " Wei Gao via ltp
2026-08-31 9:00 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903120038.8629-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox