From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18742C624D3 for ; Fri, 4 Sep 2026 12:11:27 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9219A3E0E5B for ; Fri, 4 Sep 2026 14:11:25 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id D32F43E9769 for ; Fri, 4 Sep 2026 14:09:10 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 484231A01163 for ; Fri, 4 Sep 2026 14:09:10 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EC9801FECA; Fri, 4 Sep 2026 12:09:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788523745; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=beoYaZUsHFQExTCOeG1qWIsPhookPZ8bH3l+1tciFWQ=; b=x9F77Abid59rPRzoErMVWxhrE8By/eXsrj9cP07QXtCs6oUjrK0Uont1/VfA8Cu22GVide fN0OKYaMyahwOoNYFcn3N4FRYaeBiYv76I2rkFNflCjEWVNDYsD5iJuZLvCRKa7w9CJ7aF O2ifd9LtZjexYcZ6hfFOT6kJIylGFvA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788523745; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=beoYaZUsHFQExTCOeG1qWIsPhookPZ8bH3l+1tciFWQ=; b=4/LaKIXsDPmzF+ibWwJBXPhiQjFxzx5lP4W59OdwBQe5ziy10paSjU4WVGvvLoYeoJC5uJ ittJVOj8jHBzRXDQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ew03DMxC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NvP7EnE8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788523740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=beoYaZUsHFQExTCOeG1qWIsPhookPZ8bH3l+1tciFWQ=; b=ew03DMxCakJs5sO/K1idTfK/7P2/Yav5oqZo2n6tPT67hVZumzXcG6FHFc5w5VwhEILdZ9 CFyHNl0+0w92N8CGovf+td5m4IKoKyjzGrA9fBMOrBxeOS5Pu1GoKL3akexLVo9XCCW6bh hB7olG5VYJVzpNy7Ma1XIj6S3ahm0sw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788523740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=beoYaZUsHFQExTCOeG1qWIsPhookPZ8bH3l+1tciFWQ=; b=NvP7EnE8NcXdPRTM+FLoLfQVb7UYjfyLHIjIVkEV7r3Ic0DpUhwAlSK8neiXiJxVQz+Ts9 yuC+j0+24Sqfv4Cw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D4C221398D; Fri, 4 Sep 2026 12:08:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uC5gMdW0mmpENgAAD6G6ig (envelope-from ); Fri, 04 Sep 2026 12:08:53 +0000 From: Andrea Cervesato Date: Fri, 04 Sep 2026 14:08:58 +0200 MIME-Version: 1.0 Message-Id: <20260904-keyctl_coverage-v2-9-43b78b15ef9f@suse.com> References: <20260904-keyctl_coverage-v2-0-43b78b15ef9f@suse.com> In-Reply-To: <20260904-keyctl_coverage-v2-0-43b78b15ef9f@suse.com> To: Linux Test Project X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788523731; l=2861; i=andrea.cervesato@suse.com; s=20251210; h=from:subject:message-id; bh=05fD71NTEJcluZrPisofr9AFADpoIhe3LICmG9ZX0sc=; b=echZ37UbkuFK4zzXmZS/x5DTh38167mkdYdjtcI3ai/DWw5f4MdYxG5laQ2P61MGXpeejqMyT FCDqT+bFP3JCTnfrrdRqhxBw6Zr+dOHmANfT+q6A1u5Dfn1aXTF0kFP X-Developer-Key: i=andrea.cervesato@suse.com; a=ed25519; pk=zKY+6GCauOiuHNZ//d8PQ/UL4jFCTKbXrzXAOQSLevI= X-Rspamd-Queue-Id: EC9801FECA X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.com:mid,suse.com:email]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v2 09/33] keyctl17: Negative tests for KEYCTL_GET_SECURITY X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" From: Andrea Cervesato Test error conditions of KEYCTL_GET_SECURITY using a parameterized tcase table: verify ENOKEY on a bogus key id and ENOKEY when View permission is missing (due to the kernel request-key auth token fallback path). Signed-off-by: Andrea Cervesato --- runtest/syscalls | 1 + testcases/kernel/syscalls/keyctl/.gitignore | 1 + testcases/kernel/syscalls/keyctl/keyctl17.c | 55 +++++++++++++++++++++++++++++ 3 files changed, 57 insertions(+) diff --git a/runtest/syscalls b/runtest/syscalls index 89c8a95af..fcc1d58a8 100644 --- a/runtest/syscalls +++ b/runtest/syscalls @@ -734,6 +734,7 @@ keyctl13 keyctl13 keyctl14 keyctl14 keyctl15 keyctl15 keyctl16 keyctl16 +keyctl17 keyctl17 kcmp01 kcmp01 kcmp02 kcmp02 diff --git a/testcases/kernel/syscalls/keyctl/.gitignore b/testcases/kernel/syscalls/keyctl/.gitignore index c351716d0..dddb45f85 100644 --- a/testcases/kernel/syscalls/keyctl/.gitignore +++ b/testcases/kernel/syscalls/keyctl/.gitignore @@ -14,3 +14,4 @@ /keyctl14 /keyctl15 /keyctl16 +/keyctl17 diff --git a/testcases/kernel/syscalls/keyctl/keyctl17.c b/testcases/kernel/syscalls/keyctl/keyctl17.c new file mode 100644 index 000000000..216152f1d --- /dev/null +++ b/testcases/kernel/syscalls/keyctl/keyctl17.c @@ -0,0 +1,55 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2026 Andrea Cervesato + */ + +/*\ + * Negative test cases for ``KEYCTL_GET_SECURITY`` of :manpage:`keyctl(2)`. + * + * [Algorithm] + * + * - get_security with bogus key id fails with ``ENOKEY`` + * - get_security without View permission fails with ``ENOKEY`` (the kernel + * falls back to looking for an auth token and returns its ``ENOKEY``) + */ + +#include "keyctl_common.h" + +#define BUF_SIZE 128 + +static key_serial_t key_no_view; +static key_serial_t bogus_id = INT32_MAX; +static char buf[BUF_SIZE]; + +static struct tcase { + key_serial_t *keyid; + int exp_errno; + const char *desc; +} tcases[] = { + { &bogus_id, ENOKEY, "bogus key id" }, + { &key_no_view, ENOKEY, "key without View permission" }, +}; + +static void setup(void) +{ + SAFE_KEYCTL(KEYCTL_JOIN_SESSION_KEYRING, 0, 0, 0, 0); + + key_no_view = new_user_key("k_no_view", "payload", 7, KEY_SPEC_PROCESS_KEYRING); + SAFE_KEYCTL(KEYCTL_SETPERM, key_no_view, KEY_PERM_NO_VIEW, 0, 0); +} + +static void verify_negative(unsigned int n) +{ + struct tcase *tc = &tcases[n]; + + TST_EXP_FAIL2(keyctl(KEYCTL_GET_SECURITY, (unsigned long)*tc->keyid, + (unsigned long)buf, sizeof(buf), 0), + tc->exp_errno, + "KEYCTL_GET_SECURITY with %s", tc->desc); +} + +static struct tst_test test = { + .setup = setup, + .test = verify_negative, + .tcnt = ARRAY_SIZE(tcases), +}; -- 2.51.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp