Linux Test Project
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Changwei Zou <changwei.zou@canonical.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] cpuset_memory_spread: count only the test file's page cache
Date: Sat,  5 Sep 2026 08:07:26 +0000	[thread overview]
Message-ID: <20260905080726.8660-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260905061840.14172-1-changwei.zou@canonical.com>

Hi Changwei,

On Sat, 5 Sep 2026, Changwei Zou wrote:
> cpuset_memory_spread: count only the test file's page cache

> 	for (i = 0; i < npages; i++) {
> 		if (status[i] >= 0 && status[i] < MAX_NODES)
> 			counts[status[i]]++;
> 	}

Medium: Per-page -ENOENT and -EFAULT statuses are silently omitted even
though move_pages() itself returns success, so result_check() can compute its
percentages from only a subset of DATAFILE and falsely pass. Fail on any
negative status and verify that all npages were counted.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-09-05  8:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05  6:18 [LTP] [PATCH v4] cpuset_memory_spread: count only the test file's page cache Changwei Zou via ltp
2026-09-05  8:07 ` linuxtestproject.agent [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-09-05 12:50 [LTP] [PATCH v6] " Changwei Zou via ltp
2026-09-05 15:50 ` [LTP] " linuxtestproject.agent
2026-09-05 10:19 [LTP] [PATCH v5] " Changwei Zou via ltp
2026-09-05 12:27 ` [LTP] " linuxtestproject.agent
2026-09-05  1:51 [LTP] [PATCH v3] " Changwei Zou via ltp
2026-09-05  3:06 ` [LTP] " linuxtestproject.agent
2026-09-04 12:50 [LTP] [PATCH v2] " Changwei Zou via ltp
2026-09-04 14:52 ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260905080726.8660-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=changwei.zou@canonical.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox