From: linuxtestproject.agent@gmail.com
To: Michael Menasherov <mmenashe@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] read_all: Fix buffer too small for long paths
Date: Sun, 6 Sep 2026 16:02:56 +0000 [thread overview]
Message-ID: <20260906160256.8824-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260906135650.52112-1-mmenashe@redhat.com>
Hi Michael,
On Sun, 06 Sep 2026 16:56:50 +0300, Michael Menasherov wrote:
> read_all: Fix buffer too small for long paths
> -#define BUFFER_SIZE 1024
> +#define BUFFER_SIZE 4096
queue_pop() still aborts for a 4095-byte pathname: after copying its final
byte, ++j is 4095, which satisfies BUFFER_SIZE - 1. Use PATH_MAX for popped
and compare j against PATH_MAX so every pathname that fits dent_path also
fits the queue buffer.
Verdict - Needs revision
Pre-existing issue:
read_all.c:218 has an unnecessary blank line before a closing brace, as
reported by make check.
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-09-06 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 13:56 [LTP] [PATCH] read_all: Fix buffer too small for long paths Michael Menasherov via ltp
2026-09-06 16:02 ` linuxtestproject.agent [this message]
2026-09-07 6:40 ` Andrea Cervesato via ltp
-- strict thread matches above, loose matches on Subject: below --
2026-09-07 12:03 [LTP] [PATCH v2] " Michael Menasherov via ltp
2026-09-07 14:58 ` [LTP] " linuxtestproject.agent
2026-09-08 9:22 [LTP] [PATCH v3] " Michael Menasherov via ltp
2026-09-08 10:42 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906160256.8824-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=mmenashe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).