From: linuxtestproject.agent@gmail.com
To: Pavithra <pavrampu@linux.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] hugetlb/hugemmap: add hugemmap33 to test hugetlbfs quota accounting
Date: Sun, 6 Sep 2026 16:03:41 +0000 [thread overview]
Message-ID: <20260906160341.9140-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260906150634.1032407-1-pavrampu@linux.ibm.com>
Hi Pavithra,
On 2026-09-06, Pavithra wrote:
> hugetlb/hugemmap: add hugemmap33 to test hugetlbfs quota accounting
> TST_EXP_FAIL_PTR_VOID(mmap(NULL, size, PROT_READ | PROT_WRITE, mmap_flags, fd, 0),
> ENOMEM, "mmap over quota");
> if (!TST_PASS)
> SAFE_MUNMAP(TST_RET_PTR, size);
An unexpected errno also leaves TST_PASS false but TST_RET_PTR equal to
MAP_FAILED, so SAFE_MUNMAP() reports TBROK and obscures the original failure.
Only unmap a successful mapping; the same pattern below needs the same fix.
> {"linux-git", "a1e78772d72b"},
Use the full commit ID:
a1e78772d72b2616ed20e54896e68e0e7044854e.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-09-06 16:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 15:06 [LTP] [PATCH v8] hugetlb/hugemmap: add hugemmap33 to test hugetlbfs quota accounting Pavithra
2026-09-06 16:03 ` linuxtestproject.agent [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-12 8:22 [LTP] [PATCH v10] " Pavithra
2026-09-12 11:43 ` [LTP] " linuxtestproject.agent
2026-09-09 8:55 [LTP] [PATCH v9] " Pavithra
2026-09-09 10:30 ` [LTP] " linuxtestproject.agent
2026-09-05 12:45 [LTP] [PATCH v7] " Pavithra
2026-09-05 15:58 ` [LTP] " linuxtestproject.agent
2026-09-02 7:51 [LTP] [PATCH v6] " Pavithra
2026-09-02 8:28 ` [LTP] " linuxtestproject.agent
2026-08-31 4:19 [LTP] [PATCH v5] " Pavithra
2026-08-31 9:12 ` [LTP] " linuxtestproject.agent
2026-08-09 17:49 [LTP] [PATCH v4] " Pavithra
2026-08-09 18:42 ` [LTP] " linuxtestproject.agent
2026-08-09 16:22 [LTP] [PATCH v3] " Pavithra
2026-08-09 16:38 ` [LTP] " linuxtestproject.agent
2026-08-09 15:15 [LTP] [PATCH v3] " Pavithra
2026-08-09 15:34 ` [LTP] " linuxtestproject.agent
2026-07-17 16:02 [LTP] [PATCH] " Pavithra
2026-07-17 17:15 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906160341.9140-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=pavrampu@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox