From: Andrea Cervesato <andrea.cervesato@suse.de>
To: Linux Test Project <ltp@lists.linux.it>
Subject: [LTP] [PATCH v11 1/3] lib: Add SAFE_FILE_VPRINTF()
Date: Thu, 10 Sep 2026 15:27:11 +0200 [thread overview]
Message-ID: <20260910-coredump-v11-1-e87e2100dbe3@suse.com> (raw)
In-Reply-To: <20260910-coredump-v11-0-e87e2100dbe3@suse.com>
From: Andrea Cervesato <andrea.cervesato@suse.com>
Expose safe_file_vprintf() as SAFE_FILE_VPRINTF() macro to allow
formatting directly into files with a va_list without requiring
an intermediate buffer.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
include/safe_file_ops_fn.h | 6 ++++++
include/tst_safe_file_ops.h | 14 ++++++++++++++
lib/safe_file_ops.c | 2 +-
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/include/safe_file_ops_fn.h b/include/safe_file_ops_fn.h
index 223fb0d68..1edaac794 100644
--- a/include/safe_file_ops_fn.h
+++ b/include/safe_file_ops_fn.h
@@ -20,6 +20,7 @@
#include <sys/stat.h>
#include <time.h>
+#include <stdarg.h>
#include "lapi/utime.h"
@@ -62,6 +63,11 @@ void safe_file_printf(const char *file, const int lineno,
const char *path, const char *fmt, ...)
__attribute__ ((format (printf, 5, 6)));
+void safe_file_vprintf(const char *file, const int lineno,
+ void (*cleanup_fn)(void),
+ const char *path, const char *fmt, va_list va)
+ __attribute__ ((format (printf, 5, 0)));
+
void safe_try_file_printf(const char *file, const int lineno,
void (*cleanup_fn)(void), const char *path, const char *fmt, ...)
__attribute__ ((format (printf, 5, 6)));
diff --git a/include/tst_safe_file_ops.h b/include/tst_safe_file_ops.h
index 73ebd2ab8..0fc1a160c 100644
--- a/include/tst_safe_file_ops.h
+++ b/include/tst_safe_file_ops.h
@@ -65,6 +65,20 @@ void safe_file_read_str(const char *file, const int lineno,
safe_file_printf(__FILE__, __LINE__, NULL, \
(path), (fmt), ## __VA_ARGS__)
+/**
+ * SAFE_FILE_VPRINTF() - Formats and writes a va_list argument into a file.
+ *
+ * Writes formatted output to the file at @path using the format string @fmt
+ * and variable arguments @va. Aborts the test with TBROK on failure.
+ *
+ * @path: A path to a file.
+ * @fmt: A printf format string.
+ * @va: A variable argument list.
+ */
+#define SAFE_FILE_VPRINTF(path, fmt, va) \
+ safe_file_vprintf(__FILE__, __LINE__, NULL, \
+ (path), (fmt), (va))
+
/* Same as SAFE_FILE_PRINTF() but returns quietly if the path doesn't exist */
#define SAFE_TRY_FILE_PRINTF(path, fmt, ...) \
safe_try_file_printf(__FILE__, __LINE__, NULL, \
diff --git a/lib/safe_file_ops.c b/lib/safe_file_ops.c
index 19da1fd97..1069a017f 100644
--- a/lib/safe_file_ops.c
+++ b/lib/safe_file_ops.c
@@ -280,7 +280,7 @@ err:
return 1;
}
-static void safe_file_vprintf(const char *file, const int lineno,
+void safe_file_vprintf(const char *file, const int lineno,
void (*cleanup_fn)(void), const char *path, const char *fmt,
va_list va)
{
--
2.51.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-09-10 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 13:27 [LTP] [PATCH v11 0/3] coredump testing suite Andrea Cervesato
2026-09-10 13:27 ` Andrea Cervesato [this message]
2026-09-10 15:03 ` [LTP] lib: Add SAFE_FILE_VPRINTF() linuxtestproject.agent
2026-09-10 13:27 ` [LTP] [PATCH v11 2/3] coredump01: New core_pattern specifiers test Andrea Cervesato
2026-09-10 13:27 ` [LTP] [PATCH v11 3/3] coredump02: Verify ELF structure and notes Andrea Cervesato
2026-09-11 6:34 ` [LTP] [PATCH v11 0/3] coredump testing suite Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910-coredump-v11-1-e87e2100dbe3@suse.com \
--to=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox