From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4B89C982DC for ; Fri, 18 Sep 2026 11:12:48 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 44A733E7485 for ; Fri, 18 Sep 2026 13:12:47 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 2FC3E3E168E for ; Fri, 18 Sep 2026 13:12:31 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 739BE1A0107D for ; Fri, 18 Sep 2026 13:12:30 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6220E21BBF; Fri, 18 Sep 2026 11:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789729945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CrUoficHpZMouK1EoF9sEgDwChyfmQ7QZB3AhMTIBMI=; b=enp2WpFJUKnf2tFrwWHp1NoJMWwWwNjzQbUftLwBELmV5OqaaZ8TMlrXOxp9jIBxwB2ytB hpiLtaEOGSFI3tnPAuDI3/IHncNG6VLn20ErljVHhKxCupd3yGvPYNWQeE82b2UFv3PUss Z030Jr52/3mB9R7ukvT4tsQz2t1dsKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789729945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CrUoficHpZMouK1EoF9sEgDwChyfmQ7QZB3AhMTIBMI=; b=OdzbvKF/HJHIwpM0tp7/X2ubL4qx6FVN4rdjGML2ChPkh//YQU/u9gB+N5A1yMcTDomBVw 2GnmMOislpiDmJBQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HucmdPPS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RKl3cNC5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789729941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CrUoficHpZMouK1EoF9sEgDwChyfmQ7QZB3AhMTIBMI=; b=HucmdPPS17Ky59NPS3HxJ/f8kMT6GFfqnP9iNF6Wi9DEN2AQh0WVPx0i59d3x/1wpv7r8e l3XfROFogWQrZuFbAn5L5sbjvvXj03f5X1ihm962miA8DGccpD816PgWgoiwLN/RBVY/pw MaepB3OuQ6wXY7HDPt6EEi6ryVFhpDw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789729941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CrUoficHpZMouK1EoF9sEgDwChyfmQ7QZB3AhMTIBMI=; b=RKl3cNC5JLHUcaShjAAWErdf4H53H30sJTXzBWj3/2YKQc0y37fMdbs+Bk3mtCt3IKbVtx tIeKrQqgNpGuSHBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6424F1348F; Fri, 18 Sep 2026 11:12:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 06SfOpMcrWrnKQAAD6G6ig (envelope-from ); Fri, 18 Sep 2026 11:12:20 +0000 From: Gaurav Pathak To: ltp@lists.linux.it Date: Fri, 18 Sep 2026 16:42:08 +0530 Message-ID: <20260918111208.116077-1-gpathak@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260917142345.GB1856601@pevik> References: <20260917142345.GB1856601@pevik> MIME-Version: 1.0 X-Rspamd-Queue-Id: 6220E21BBF X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[configure.ac:url,suse.com:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Virus-Scanned: clamav-milter 1.0.9 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v3] syscalls/statx13: Add basic test for STATX_WRITE_ATOMIC on regular file X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gaurav Pathak Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" From: Gaurav Pathak This patch adds a new test to validate these atomic write limit fields. The test ensures the filesystem correctly advertises the STATX_ATTR_WRITE_ATOMIC attribute when queried on a file opened with O_DIRECT. It also verifies that the reported optimized maximum is logically consistent by falling within the absolute minimum and maximum boundaries. Furthermore, it checks that all reported atomic write unit sizes are valid powers of two, adhering to the strict requirements of the kernel block layer. If the underlying storage hardware or filesystem lacks atomic write support, the test gracefully skips with TCONF. Closes: #1224 Signed-off-by: Gaurav Pathak --- configure.ac | 4 +- include/lapi/stat.h | 17 ++- runtest/syscalls | 1 + testcases/kernel/syscalls/statx/.gitignore | 1 + testcases/kernel/syscalls/statx/statx13.c | 139 +++++++++++++++++++++ 5 files changed, 160 insertions(+), 2 deletions(-) create mode 100644 testcases/kernel/syscalls/statx/statx13.c diff --git a/configure.ac b/configure.ac index 18bfdb88c..d5a609fa7 100644 --- a/configure.ac +++ b/configure.ac @@ -181,7 +181,9 @@ AC_CHECK_MEMBERS([struct iocb.aio_rw_flags],,,[#include ]) AC_CHECK_MEMBERS([struct fanotify_event_info_fid.fsid.__val],,,[#include ]) AC_CHECK_MEMBERS([struct perf_event_mmap_page.aux_head],,,[#include ]) AC_CHECK_MEMBERS([struct sigaction.sa_sigaction],[],[],[#include ]) -AC_CHECK_MEMBERS([struct statx.stx_mnt_id, struct statx.stx_dio_mem_align],,,[ +AC_CHECK_MEMBERS([struct statx.stx_mnt_id, struct statx.stx_dio_mem_align, struct statx.stx_atomic_write_unit_max_opt, + struct statx.stx_atomic_write_unit_min, struct statx.stx_atomic_write_unit_max, + struct statx.stx_atomic_write_segments_max],,,[ #define _GNU_SOURCE #include ]) diff --git a/include/lapi/stat.h b/include/lapi/stat.h index 17b62ea98..859e410ab 100644 --- a/include/lapi/stat.h +++ b/include/lapi/stat.h @@ -93,7 +93,14 @@ struct statx_timestamp { uint64_t stx_mnt_id; \ uint32_t stx_dio_mem_align; \ uint32_t stx_dio_offset_align; \ - uint64_t __spare3[12]; \ + uint64_t stx_subvol; \ + uint32_t stx_atomic_write_unit_min; \ + uint32_t stx_atomic_write_unit_max; \ + uint32_t stx_atomic_write_segments_max; \ + uint32_t stx_dio_read_offset_align; \ + uint32_t stx_atomic_write_unit_max_opt; \ + uint32_t __spare2[1]; \ + uint64_t __spare3[8]; \ }; LTP_DEFINE_STATX_STRUCT(statx_fallback); @@ -197,6 +204,10 @@ static inline int statx(int dirfd, const char *pathname, unsigned int flags, # define STATX_DIOALIGN 0x00002000U #endif +#ifndef STATX_WRITE_ATOMIC +#define STATX_WRITE_ATOMIC 0x00010000U +#endif + #ifndef STATX__RESERVED # define STATX__RESERVED 0x80000000U #endif @@ -248,6 +259,10 @@ static inline int statx(int dirfd, const char *pathname, unsigned int flags, # define STATX_MNT_ID_UNIQUE 0x00004000U #endif +#ifndef STATX_ATTR_WRITE_ATOMIC +#define STATX_ATTR_WRITE_ATOMIC 0x00400000 +#endif + #define SAFE_FCHMODAT2(dfd, filename, mode, flags) \ safe_fchmodat2(__FILE__, __LINE__, (dfd), (filename), (mode), (flags)) diff --git a/runtest/syscalls b/runtest/syscalls index d953f0558..b8c7fbb0f 100644 --- a/runtest/syscalls +++ b/runtest/syscalls @@ -1926,6 +1926,7 @@ statx09 statx09 statx10 statx10 statx11 statx11 statx12 statx12 +statx13 statx13 membarrier01 membarrier01 diff --git a/testcases/kernel/syscalls/statx/.gitignore b/testcases/kernel/syscalls/statx/.gitignore index f6a423eed..e601a46a3 100644 --- a/testcases/kernel/syscalls/statx/.gitignore +++ b/testcases/kernel/syscalls/statx/.gitignore @@ -10,3 +10,4 @@ /statx10 /statx11 /statx12 +/statx13 diff --git a/testcases/kernel/syscalls/statx/statx13.c b/testcases/kernel/syscalls/statx/statx13.c new file mode 100644 index 000000000..cc445fa57 --- /dev/null +++ b/testcases/kernel/syscalls/statx/statx13.c @@ -0,0 +1,139 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2026 SUSE LLC + */ + +/*\ + * This test validates the STATX_WRITE_ATOMIC feature (introduced in Linux 6.13). + * It ensures that supported filesystems (xfs and nfs) correctly report their + * atomic write limits to user space when queried via statx(). + * + * The test performs the following validations: + * + * - Creates a test file using O_DIRECT (a prerequisite for atomic writes). + * - Calls statx() with the STATX_WRITE_ATOMIC mask to retrieve the limits. + * - Verifies that stx_atomic_write_unit_min, stx_atomic_write_unit_max, and + * stx_atomic_write_unit_max_opt are logically consistent (e.g., max_opt is + * within the min and max bounds). + * - Ensures all reported atomic write unit sizes are valid powers of two. + */ + +#define _GNU_SOURCE +#include "tst_test.h" +#include "lapi/stat.h" + +#define MNTPOINT "mnt_point" +#define TESTFILE MNTPOINT "/testfile" +#define MODE 0644 + +#define WRITE_SIZE 4096 +#define ALIGNMENT 4096 + +static int file_fd = -1; + +static void verify_statx(void) +{ + struct ltp_statx buff; + + TST_EXP_PASS_SILENT(SAFE_STATX(AT_FDCWD, TESTFILE, 0, STATX_BASIC_STATS | STATX_WRITE_ATOMIC, &buff)); + + if (!TST_PASS) + return; + + if (!(buff.data.stx_attributes & STATX_ATTR_WRITE_ATOMIC)) + tst_brk(TCONF, "Filesystem does not support STATX_WRITE_ATOMIC"); + +#if HAVE_STRUCT_STATX_STX_ATOMIC_WRITE_UNIT_MIN + if (buff.data.stx_atomic_write_unit_min <= buff.data.stx_atomic_write_unit_max) + tst_res(TPASS, "stx_atomic_write_unit_min(%u) <= stx_atomic_write_unit_max(%u)", + buff.data.stx_atomic_write_unit_min, buff.data.stx_atomic_write_unit_max); + else + tst_res(TFAIL, "stx_atomic_write_unit_min(%u) > stx_atomic_write_unit_max(%u)", + buff.data.stx_atomic_write_unit_min, buff.data.stx_atomic_write_unit_max); + + if (buff.data.stx_atomic_write_unit_min > 0 && + __builtin_popcount(buff.data.stx_atomic_write_unit_min) == 1) + tst_res(TPASS, "stx_atomic_write_unit_min(%u) is power of 2", + buff.data.stx_atomic_write_unit_min); + else + tst_res(TFAIL, "stx_atomic_write_unit_min(%u) is not a power of 2", + buff.data.stx_atomic_write_unit_min); + + if (buff.data.stx_atomic_write_unit_max > 0 && + __builtin_popcount(buff.data.stx_atomic_write_unit_max) == 1) + tst_res(TPASS, "stx_atomic_write_unit_max(%u) is power of 2", + buff.data.stx_atomic_write_unit_max); + else + tst_res(TFAIL, "stx_atomic_write_unit_max(%u) is not a power of 2", + buff.data.stx_atomic_write_unit_max); +#else + tst_res(TCONF, "stx_atomic_write_unit_max or stx_atomic_write_unit_min is not defined in struct statx"); +#endif + +#if HAVE_STRUCT_STATX_STX_ATOMIC_WRITE_UNIT_MAX_OPT + if (buff.data.stx_atomic_write_unit_max_opt == 0) { + tst_res(TPASS, "stx_atomic_write_unit_max_opt is 0 (no optimized max reported)"); + } else { + if (buff.data.stx_atomic_write_unit_max_opt > buff.data.stx_atomic_write_unit_max) + tst_res(TFAIL, "stx_atomic_write_unit_max_opt (%u) exceeds max (%u)", + buff.data.stx_atomic_write_unit_max_opt, + buff.data.stx_atomic_write_unit_max); + + else if (buff.data.stx_atomic_write_unit_max_opt < buff.data.stx_atomic_write_unit_min) + tst_res(TFAIL, "stx_atomic_write_unit_max_opt (%u) is less than min (%u)", + buff.data.stx_atomic_write_unit_max_opt, + buff.data.stx_atomic_write_unit_min); + else + tst_res(TPASS, "stx_atomic_write_unit_max_opt (%u) is within valid range [%u, %u]", + buff.data.stx_atomic_write_unit_max_opt, + buff.data.stx_atomic_write_unit_min, + buff.data.stx_atomic_write_unit_max); + + if (__builtin_popcount(buff.data.stx_atomic_write_unit_max_opt) != 1) + tst_res(TFAIL, "stx_atomic_write_unit_max_opt (%u) is not a power of 2", + buff.data.stx_atomic_write_unit_max_opt); + } +#else + tst_res(TCONF, "stx_atomic_write_unit_max_opt is not defined in struct statx"); +#endif +} + +static void setup(void) +{ + char *data_buff = SAFE_MEMALIGN(ALIGNMENT, WRITE_SIZE); + + umask(0); + memset(data_buff, '@', WRITE_SIZE); + + file_fd = SAFE_OPEN(TESTFILE, O_RDWR | O_CREAT | O_DIRECT, MODE); + SAFE_WRITE(SAFE_WRITE_ALL, file_fd, data_buff, WRITE_SIZE); + + free(data_buff); +} + +static void cleanup(void) +{ + if (file_fd != -1) + SAFE_CLOSE(file_fd); +} + +static struct tst_test test = { + .test_all = verify_statx, + .setup = setup, + .cleanup = cleanup, + .min_kver = "6.11", + .needs_root = 1, + .mntpoint = MNTPOINT, + .mount_device = 1, + .filesystems = (struct tst_fs[]) { + { + .type = "xfs", + .mkfs_opts = (const char *const []){"-f", "-bsize=16K", NULL}, + }, + { + .type = "ext4", + .mkfs_opts = (const char *const []){"-O", "bigalloc", "-b", "4096", "-C", "65536", NULL}, + }, + {} + }, +}; -- 2.51.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp