Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] openposix: lib: Use the configured compiler
Date: Tue, 29 Sep 2026 17:07:43 +0200	[thread overview]
Message-ID: <20260929150743.GE2462033@pevik> (raw)
In-Reply-To: <20260928212721.2834101-1-anders.roxell@linaro.org>

Hi Anders,

> The lib Makefile does not include env.mk, so it does not get CC from
> config.mk. When we cross compile, libcommon.a gets built with the host
> compiler. Then the linker skips it and most tests fail to build.

> Include env.mk, like the other Makefiles do.

Make sense, thanks!
Verified and merged even close before the release.

Kind regards,
Petr

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>  testcases/open_posix_testsuite/lib/Makefile | 2 ++
>  1 file changed, 2 insertions(+)

> diff --git a/testcases/open_posix_testsuite/lib/Makefile b/testcases/open_posix_testsuite/lib/Makefile
> index ad6a9d7e6a1b..e63ee42647ac 100644
> --- a/testcases/open_posix_testsuite/lib/Makefile
> +++ b/testcases/open_posix_testsuite/lib/Makefile
> @@ -1,6 +1,8 @@
>  top_srcdir?=		..
>  subdir=			lib

> +include $(top_srcdir)/include/mk/env.mk
> +
>  AR?=			ar
>  RANLIB?=		ranlib
>  CFLAGS+=		-I$(top_srcdir)/include

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      parent reply	other threads:[~2026-09-29 15:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 21:27 [LTP] [PATCH] openposix: lib: Use the configured compiler Anders Roxell
2026-09-28 23:47 ` [LTP] " linuxtestproject.agent
2026-09-29 15:07 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929150743.GE2462033@pevik \
    --to=pvorel@suse.cz \
    --cc=anders.roxell@linaro.org \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox