Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] lib: Handle empty saved configuration values
Date: Tue, 29 Sep 2026 17:23:26 +0200	[thread overview]
Message-ID: <20260929152326.GF2462033@pevik> (raw)
In-Reply-To: <20260929-fix_fw_load02-v1-1-4cd5f95d172b@suse.com>

Hi Andrea,

> Empty string module parameters return EOF on older kernels, causing
> fw_load02 to abort with TBROK on v4.4.

> Accept empty values while retaining read-error handling and the original
> errno. Restore empty strings with a NUL byte: an empty write does not
> invoke the sysfs setter, while a newline would change the saved value.

Thanks for the fix, LGTM.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
> Fix the following behaviour on kernel < 4.14 96802e6b1dbf

Could you please put kernel version and git hash to the commit message?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-09-29 15:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 14:15 [LTP] [PATCH] lib: Handle empty saved configuration values Andrea Cervesato
2026-09-29 15:12 ` Cyril Hrubis
2026-09-29 15:23 ` Petr Vorel [this message]
2026-09-29 16:16 ` Martin Doucha
2026-09-29 17:50 ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929152326.GF2462033@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox