Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] openposix: timers/twoevtimers: Wait for both timer signals
Date: Mon, 12 Oct 2026 11:33:57 +0200	[thread overview]
Message-ID: <20261012093357.GA191096@pevik> (raw)
In-Reply-To: <b6d98d03422ec30d0bf5284cd094d2ecf688efe3.1791792065.git.jstancek@redhat.com>

Hi Jan,

thanks, LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

> -#define EXPIREDELTA 3
> -#define LONGTIME 5
> +#define EXPIREDELTA_NS 50000000

very nit: having EXPIREDELTA_MS 50 and then use EXPIREDELTA_MS * 1000000
might be slightly more readable.

> +#define LONGTIME 3
> +
> +#define POLL_MS 50
> +#define POLL_COUNT (LONGTIME * 1000 / POLL_MS)

>  #define CHILDPASS 1

> -static int caughtabort = 0;
> -static int caughtalarm = 0;
> +static volatile sig_atomic_t caughtabort = 0;
> +static volatile sig_atomic_t caughtalarm = 0;
nit: static is 0 already (maybe drop "= 0"?)

> -static void handler_abrt(int signo)
> +static void handler_abrt(int signo PTS_ATTRIBUTE_UNUSED)
Thanks for silence some of the warnings.

>  {
> -	printf("Caught abort signal\n");
+1

>  	caughtabort++;
>  }

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-10-12  9:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09  6:49 [LTP] [PATCH] openposix: timers/twoevtimers: Wait for both timer signals Jan Stancek via ltp
2026-10-09 10:09 ` [LTP] " linuxtestproject.agent
2026-10-09 10:52 ` [LTP] [PATCH v2] " Jan Stancek via ltp
2026-10-09 17:26   ` [LTP] " linuxtestproject.agent
2026-10-10  9:06     ` Li Wang
2026-10-10  9:42       ` Jan Stancek via ltp
2026-10-11  1:07         ` Li Wang
2026-10-12  4:56   ` [LTP] [PATCH v3] " Jan Stancek via ltp
2026-10-12  7:19     ` [LTP] " linuxtestproject.agent
2026-10-12  8:03     ` [LTP] [PATCH v4] " Jan Stancek via ltp
2026-10-12  9:33       ` Petr Vorel [this message]
2026-10-12 15:47       ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261012093357.GA191096@pevik \
    --to=pvorel@suse.cz \
    --cc=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox