Re: [LTP] syscalls/connect02: Handle IPV6_ADDRFORM removal and listen() EINVAL

[linuxtestproject.agent@gmail.com]

Hi Ramesh,

On Wed, 14 Oct 2026 09:56:16 +0200, Ramesh Chhetri wrote:
> syscalls/connect02: Handle IPV6_ADDRFORM removal and listen() EINVAL

> @@ -91,6 +91,14 @@ static void run(void)
> +			if (TST_ERR == ENOPROTOOPT || TST_ERR == EOPNOTSUPP) {
> +				tst_brk(TCONF | TTERRNO,
> +					"IPV6_ADDRFORM is removed/unsupported by this kernel");

High: A kernel containing b6f6118901d1 without 82c9ae440857 returns
ENOPROTOOPT here because its TCP branch leaves retv at -ENOPROTOOPT.
This turns the existing regression check's TFAIL into TCONF.
Distinguish removal, for example with getsockopt(IPV6_ADDRFORM) on fd
before closing it, and retain TFAIL when the option still exists.

> @@ -104,7 +112,15 @@ static void run(void)
> +			if (TST_ERR == EINVAL) {
> +				SAFE_CLOSE(fd);
> +				SAFE_CLOSE(confd1);
> +				continue;
> +			}

Medium: When 8cc3aef0cb19 rejects this transition, all 1000 iterations take
this branch and the function reports TPASS without reaching the second
connect()/accept() that exercises CVE-2018-9568.
Report TCONF when the transition is unavailable instead of silently
continuing to a pass.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp