Linux Test Project
 help / color / mirror / Atom feed
From: Andrea Cervesato <andrea.cervesato@suse.de>
To: Linux Test Project <ltp@lists.linux.it>
Subject: [LTP] [PATCH v5 08/14] fchroot07: test execve blocked by failfs root
Date: Tue, 20 Oct 2026 12:16:37 +0200	[thread overview]
Message-ID: <20261020-fchroot-v5-8-63aa6faff503@suse.com> (raw)
In-Reply-To: <20261020-fchroot-v5-0-63aa6faff503@suse.com>

From: Andrea Cervesato <andrea.cervesato@suse.com>

Verify that after fchroot() moved the root into failfs, loading a
binary by absolute path fails with EOPNOTSUPP. The exec runs in a
grandchild so a wrongly successful exec is still detected through
the exit code.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 runtest/syscalls                                   |  1 +
 testcases/kernel/syscalls/fchroot/.gitignore       |  2 +
 testcases/kernel/syscalls/fchroot/fchroot07.c      | 58 ++++++++++++++++++++++
 .../kernel/syscalls/fchroot/fchroot07_child.c      | 16 ++++++
 4 files changed, 77 insertions(+)

diff --git a/runtest/syscalls b/runtest/syscalls
index 8b688cbe2..bc2dffdca 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -322,6 +322,7 @@ fchroot03 fchroot03
 fchroot04 fchroot04
 fchroot05 fchroot05
 fchroot06 fchroot06
+fchroot07 fchroot07
 
 fcntl01 fcntl01
 fcntl01_64 fcntl01_64
diff --git a/testcases/kernel/syscalls/fchroot/.gitignore b/testcases/kernel/syscalls/fchroot/.gitignore
index 12151270a..bfa2a8ce1 100644
--- a/testcases/kernel/syscalls/fchroot/.gitignore
+++ b/testcases/kernel/syscalls/fchroot/.gitignore
@@ -4,3 +4,5 @@ fchroot03
 fchroot04
 fchroot05
 fchroot06
+fchroot07
+fchroot07_child
diff --git a/testcases/kernel/syscalls/fchroot/fchroot07.c b/testcases/kernel/syscalls/fchroot/fchroot07.c
new file mode 100644
index 000000000..0bd16890d
--- /dev/null
+++ b/testcases/kernel/syscalls/fchroot/fchroot07.c
@@ -0,0 +1,58 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2026 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
+ */
+
+/*\
+ * Test that :manpage:`execve(2)` is blocked under the failfs root.
+ *
+ * After :manpage:`fchroot(2)` moved the process root into failfs, loading
+ * a binary by absolute path fails with ``EOPNOTSUPP``.
+ *
+ * Root is required because entering failfs with the ``FD_FAILFS_ROOT``
+ * sentinel requires ``CAP_SYS_CHROOT``.
+ *
+ * The test runs in a forked child so the root of the parent process is
+ * left untouched.
+ */
+
+#define _GNU_SOURCE
+#include <unistd.h>
+#include "tst_test.h"
+#include "lapi/fcntl.h"
+#include "lapi/syscalls.h"
+
+#define CHILD_EXEC "fchroot07_child"
+
+static char child_path[PATH_MAX];
+
+static void run(void)
+{
+	if (SAFE_FORK())
+		return;
+
+	TST_EXP_PASS(tst_syscall(__NR_fchroot, FD_FAILFS_ROOT, 0),
+		"fchroot() with the FD_FAILFS_ROOT sentinel");
+
+	if (!SAFE_FORK()) {
+		TST_EXP_FAIL(execl(child_path, CHILD_EXEC, NULL), EOPNOTSUPP,
+			"absolute exec blocked by the failfs root");
+		return;
+	}
+
+	SAFE_WAIT(NULL);
+}
+
+static void setup(void)
+{
+	if (tst_get_path(CHILD_EXEC, child_path, sizeof(child_path)))
+		tst_brk(TCONF, "Couldn't find %s in $PATH", CHILD_EXEC);
+}
+
+static struct tst_test test = {
+	.setup = setup,
+	.test_all = run,
+	.needs_root = 1,
+	.forks_child = 1,
+	.child_needs_reinit = 1,
+};
diff --git a/testcases/kernel/syscalls/fchroot/fchroot07_child.c b/testcases/kernel/syscalls/fchroot/fchroot07_child.c
new file mode 100644
index 000000000..3d731781c
--- /dev/null
+++ b/testcases/kernel/syscalls/fchroot/fchroot07_child.c
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2026 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
+ */
+
+#define TST_NO_DEFAULT_MAIN
+#include "tst_test.h"
+
+int main(void)
+{
+	tst_reinit();
+
+	tst_res(TFAIL, "child executed");
+
+	return 0;
+}

-- 
2.51.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-10-20 10:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 10:16 [LTP] [PATCH v5 00/14] fchroot: add fchroot() testing suite Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 01/14] lapi: fallback fchroot() parameters Andrea Cervesato
2026-10-20 12:39   ` Cyril Hrubis
2026-10-20 14:53   ` [LTP] " linuxtestproject.agent
2026-10-20 15:57     ` Andrea Cervesato via ltp
2026-10-20 10:16 ` [LTP] [PATCH v5 02/14] fchroot01: test fchroot() with a directory fd Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 03/14] fchroot02: test fchroot() invalid arguments Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 04/14] fchroot03: test fchroot() permission checks Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 05/14] fchroot04: test fchroot() into failfs as root Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 06/14] fchroot05: test failfs root can not be referenced Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 07/14] fchroot06: test path walks under failfs root Andrea Cervesato
2026-10-20 13:02   ` Cyril Hrubis
2026-10-20 10:16 ` Andrea Cervesato [this message]
2026-10-20 10:16 ` [LTP] [PATCH v5 09/14] fchroot08: test failfs root fork inheritance Andrea Cervesato
2026-10-20 13:05   ` Cyril Hrubis
2026-10-20 10:16 ` [LTP] [PATCH v5 10/14] fchroot09: test setns escape from failfs root Andrea Cervesato
2026-10-20 15:26   ` Cyril Hrubis
2026-10-20 10:16 ` [LTP] [PATCH v5 11/14] fchroot10: test failfs entry without no_new_privs Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 12/14] fchroot11: test failfs entry with no_new_privs Andrea Cervesato
2026-10-20 15:41   ` Cyril Hrubis
2026-10-20 10:16 ` [LTP] [PATCH v5 13/14] fchroot12: test failfs entry with shared fs_struct Andrea Cervesato
2026-10-20 10:16 ` [LTP] [PATCH v5 14/14] fchroot13: test failfs entry when chrooted Andrea Cervesato
2026-10-20 15:44   ` Cyril Hrubis
2026-10-20 16:13 ` [LTP] [PATCH v5 00/14] fchroot: add fchroot() testing suite Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261020-fchroot-v5-8-63aa6faff503@suse.com \
    --to=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox