From: linuxtestproject.agent@gmail.com
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] build: Fix library prerequisites in testcases.mk
Date: Wed, 21 Oct 2026 13:40:50 +0000 [thread overview]
Message-ID: <20261021134051.78448-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20261021-build_system_optimize-v3-1-71a3c4c6f937@suse.com>
Hi Andrea,
On Wed, 21 Oct 2026, Andrea Cervesato wrote:
> build: Fix library prerequisites in testcases.mk
--- [PATCH 3/3] ---
> diff --git a/include/mk/generic_trunk_target.inc b/include/mk/generic_trunk_target.inc
> +$(addsuffix -all,$(SUBDIRS)): trunk-all | $(SUBDIRS) $(MAKE_DEPS)
Medium severity: make -C testcases/kernel/syscalls -j4 SUBDIRS=getuid
now exits 2 because the shared-library sub-make inherits SUBDIRS=getuid
and looks for libs/getuid/Makefile. The same command succeeds before this
patch; keep the test-directory selection out of shared-library sub-makes.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-10-21 13:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 8:11 [LTP] [PATCH v3 0/3] Speedup LTP compile time by ~20% on multi-machine Andrea Cervesato
2026-10-21 8:11 ` [LTP] [PATCH v3 1/3] build: Fix library prerequisites in testcases.mk Andrea Cervesato
2026-10-21 13:40 ` linuxtestproject.agent [this message]
2026-10-21 8:11 ` [LTP] [PATCH v3 2/3] build: Build shared libs once on subtree make Andrea Cervesato
2026-10-21 8:11 ` [LTP] [PATCH v3 3/3] build: Parallelize subdirectory recursion in generic_trunk_target Andrea Cervesato
-- strict thread matches above, loose matches on Subject: below --
2026-10-20 16:42 [LTP] [PATCH v2 1/3] build: Fix library prerequisites in testcases.mk Andrea Cervesato
2026-10-20 19:04 ` [LTP] " linuxtestproject.agent
2026-10-21 8:06 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021134051.78448-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox