From: linuxtestproject.agent@gmail.com
To: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] binfmt_misc02.sh: Fix interpreter with uutils/coreutils
Date: Thu, 22 Oct 2026 13:35:19 +0000 [thread overview]
Message-ID: <20261022133519.4037-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20261021024758.13541-1-kuan-ying.lee@canonical.com>
Hi Kuan-Ying,
On Wed, 21 Oct 2026, Kuan-Ying Lee wrote:
> binfmt_misc02.sh: Fix interpreter with uutils/coreutils
> + interp_dir=$(mktemp -d "$TMPDIR/ltp_binfmt_miscXXXXXX")
> + [ -d "$interp_dir" ] || tst_brk TBROK "Failed to create interpreter dir"
With TMPDIR on a noexec filesystem and the datafiles on an executable
filesystem, open_exec() rejects this new interpreter with EACCES, causing
subtests 1-4 to report TFAIL despite working binfmt_misc support. The
previous system-cat interpreter did not depend on TMPDIR being executable.
Detect a noexec TMPDIR during setup and report TCONF, or place the wrapper
on an executable filesystem.
> + printf '#!/bin/sh\nexec %s "$1"\n' "$(command -v cat)" > "$interp" ||
The resolved cat pathname is inserted unquoted into shell source: with
cat in a PATH directory containing spaces, the generated exec command
splits the pathname and exits 127 instead of running cat. Generate a
literal exec cat "$1" command instead, letting the shell perform PATH
lookup without reparsing the resolved pathname.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-10-22 13:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 2:47 [LTP] [PATCH] binfmt_misc02.sh: Fix interpreter with uutils/coreutils Kuan-Ying Lee via ltp
2026-10-22 13:35 ` linuxtestproject.agent [this message]
2026-10-22 13:57 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2026-10-12 6:03 Kuan-Ying Lee via ltp
2026-10-22 13:36 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022133519.4037-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=kuan-ying.lee@canonical.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox