From: Petr Vorel <pvorel@suse.cz>
To: linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it
Subject: Re: [LTP] nfsstat02.sh: Properly fix netns enforcement
Date: Fri, 30 Oct 2026 16:20:36 +0100 [thread overview]
Message-ID: <20261030152036.GA4701@pevik> (raw)
In-Reply-To: <20261030133732.3727-1-linuxtestproject.agent@gmail.com>
> Hi Petr,
> On Fri Oct 30 12:36:37 2026 +0100, Petr Vorel <pvorel@suse.cz> wrote:
> > nfsstat02.sh: Properly fix netns enforcement
> > diff --git a/testcases/network/nfs/nfsstat01/nfsstat02.sh b/testcases/network/nfs/nfsstat01/nfsstat02.sh
> > index 75a1a01b5..193a52b59 100755
> > --- a/testcases/network/nfs/nfsstat01/nfsstat02.sh
> > +++ b/testcases/network/nfs/nfsstat01/nfsstat02.sh
> > @@ -20,7 +20,7 @@ do_test()
> > }
> > # Force use of nested net namespace
> > -unset RHOST
> > +tst_net_use_netns || tst_net_unset_2_hosts_variables
> > . nfs_lib.sh
> > tst_run
> tst_net_use_netns and tst_net_unset_2_hosts_variables are called before
> nfs_lib.sh (which sources tst_net.sh) is sourced, so both functions are
> undefined at this point and fail with "not found". Calling them after
> sourcing nfs_lib.sh is also too late because tst_net.sh already evaluates
> RHOST and runs tst_net_setup_network at top level while being sourced. Set a
> variable such as TST_NET_FORCE_NETNS=1 before sourcing nfs_lib.sh and handle
> unsetting the 2-host variables inside tst_net.sh before the RHOST check.
I must have been really tired to overlook so obvious error.
TST_NET_FORCE_NETNS might be overkill, but I really prefer have that code in the
library than broken test due forget to set some variable.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-10-30 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 11:36 [LTP] [PATCH 1/1] nfsstat02.sh: Properly fix netns enforcement Petr Vorel
2026-10-30 13:37 ` [LTP] " linuxtestproject.agent
2026-10-30 15:20 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030152036.GA4701@pevik \
--to=pvorel@suse.cz \
--cc=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox