[LTP] [PATCH v3] accept03/tst_fd: Harden parallel runs against shared path races

[Stephen Bertram via ltp <ltp@lists.linux.it>]

From: Stephen Bertram <sbertram@redhat.com>

TST_FD_FOREACH in accept03, epoll_pwait06, ioctl_pidfd01, and
splice07 creates fixed fd_file and fd_dir names in the current
directory. Parallel runs that share that directory race on those
names. Set .needs_tmpdir so each run gets its own directory.

Signed-off-by: Stephen Bertram <sbertram@redhat.com>
---
 testcases/kernel/syscalls/accept/accept03.c           | 1 +
 testcases/kernel/syscalls/epoll_pwait/epoll_pwait06.c | 1 +
 testcases/kernel/syscalls/ioctl/ioctl_pidfd01.c       | 1 +
 testcases/kernel/syscalls/splice/splice07.c           | 1 +
 4 files changed, 4 insertions(+)

diff --git a/testcases/kernel/syscalls/accept/accept03.c b/testcases/kernel/syscalls/accept/accept03.c
index bc472397d..dea4988cf 100644
--- a/testcases/kernel/syscalls/accept/accept03.c
+++ b/testcases/kernel/syscalls/accept/accept03.c
@@ -55,4 +55,5 @@ static void verify_accept(void)
 
 static struct tst_test test = {
 	.test_all = verify_accept,
+	.needs_tmpdir = 1,
 };
diff --git a/testcases/kernel/syscalls/epoll_pwait/epoll_pwait06.c b/testcases/kernel/syscalls/epoll_pwait/epoll_pwait06.c
index e12d9d394..b30b7289b 100644
--- a/testcases/kernel/syscalls/epoll_pwait/epoll_pwait06.c
+++ b/testcases/kernel/syscalls/epoll_pwait/epoll_pwait06.c
@@ -78,6 +78,7 @@ static void cleanup(void)
 
 static struct tst_test test = {
 	.test_all = run,
+	.needs_tmpdir = 1,
 	.setup = setup,
 	.cleanup = cleanup,
 	.test_variants = TEST_VARIANTS,
diff --git a/testcases/kernel/syscalls/ioctl/ioctl_pidfd01.c b/testcases/kernel/syscalls/ioctl/ioctl_pidfd01.c
index 95c0e8f3f..629bc2a1e 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_pidfd01.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_pidfd01.c
@@ -56,6 +56,7 @@ static void setup(void)
 
 static struct tst_test test = {
 	.test_all = run,
+	.needs_tmpdir = 1,
 	.setup = setup,
 	.forks_child = 1,
 	.bufs = (struct tst_buffers []) {
diff --git a/testcases/kernel/syscalls/splice/splice07.c b/testcases/kernel/syscalls/splice/splice07.c
index c750a14bf..c42e7ecd3 100644
--- a/testcases/kernel/syscalls/splice/splice07.c
+++ b/testcases/kernel/syscalls/splice/splice07.c
@@ -69,4 +69,5 @@ static void verify_splice(void)
 
 static struct tst_test test = {
 	.test_all = verify_splice,
+	.needs_tmpdir = 1,
 };
-- 
2.55.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp