From: Avinesh Kumar <akumar@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] tst_tmpdir: Add 'LTP_' prefix
Date: Wed, 11 Jan 2023 18:48:27 +0530 [thread overview]
Message-ID: <2068101.vSGb3dL7Gk@localhost> (raw)
In-Reply-To: <20230110183555.6915-1-pvorel@suse.cz>
Hi,
Reviewed-by: Avinesh Kumar <akumar@suse.de>
On Wednesday, January 11, 2023 12:05:55 AM IST Petr Vorel wrote:
> Follow the approach of the shell API:
>
> TST_TMPDIR=$(mktemp -d "$TMPDIR/LTP_$TST_ID.XXXXXXXXXX")
>
> Prefix helps to see directories mounted by LTP.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> lib/tst_tmpdir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/tst_tmpdir.c b/lib/tst_tmpdir.c
> index d1419a1a40..b73b5c66f7 100644
> --- a/lib/tst_tmpdir.c
> +++ b/lib/tst_tmpdir.c
> @@ -269,7 +269,7 @@ void tst_tmpdir(void)
> * use our default TEMPDIR.
> */
> env_tmpdir = tst_get_tmpdir_root();
> - snprintf(template, PATH_MAX, "%s/%.3sXXXXXX", env_tmpdir, TCID);
> + snprintf(template, PATH_MAX, "%s/LTP_%.3sXXXXXX", env_tmpdir, TCID);
>
> /* Make the temporary directory in one shot using mkdtemp. */
> if (mkdtemp(template) == NULL) {
>
Regards,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-01-11 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 18:35 [LTP] [PATCH 1/1] tst_tmpdir: Add 'LTP_' prefix Petr Vorel
2023-01-11 13:18 ` Avinesh Kumar [this message]
2023-01-12 10:33 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2068101.vSGb3dL7Gk@localhost \
--to=akumar@suse.de \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox