[LTP] [PATCH 2/2] lib: build check parameters for tst_brk()

Xiao Yang
2018-12-06T09:19:32Z

Hi all,

Sorry, i forgot to reply this mail. :-(

On 2018/12/06 16:49, Li Wang wrote:
> On Wed, Dec 5, 2018 at 5:25 PM Petr Vorel<pvorel@suse.cz> wrote:
>> Hi Li, Jan,
>>
>>>>> Alternative would be link time failure, with a symbol name suggesting what went wrong.
>>>> Not sure, how exactly you want to do it, but seems to be more portable than
>>>> requiring specific gcc version (although 4.3 is very old and __attribute__
>>>> format is supported by clang as well).
>>> I took an rough look at the kernel method, maybe we can achieve that
>>> conditionally?
>>> --- a/include/tst_common.h
>>> +++ b/include/tst_common.h
>>> @@ -65,4 +65,23 @@
>>> ERET; \
>>> })
>>> +#define GCC_VERSION (__GNUC__ * 10000 \
>>> + + __GNUC_MINOR__ * 100 \
>>> + + __GNUC_PATCHLEVEL__)
>>> +
>>> +#if GCC_VERSION>= 40300
>> Didn't you mean reverse?
>> #if GCC_VERSION< 40300
> No, I saw kernel gives this limitation so just use it as that.
> See: https://github.com/torvalds/linux/blob/master/include/linux/build_bug.h#L55
>
>> But this idea does not work for clang, which always use same version:
>> __GNUC__: 4
>> __GNUC_MINOR__: 2
>> __GNUC_PATCHLEVEL__: 1
>> (tested on clang 3.9, 5.0, 6.0)
> Noticed the Travis CI Build #860 works fine with clang, did you config
> anything special for that? BTW, the remain error part of GCC is not
> the same issue here, see below comments.
>
> Build #860:
> https://travis-ci.org/pevik/ltp/builds/463720369
> https://github.com/pevik/ltp/commit/643bceea36c3447add142fcb5e7a3f79e9ac65a2
>
>> There should be also CLANG_VERSION
>> __clang_major__
>> __clang_minor__
>> __clang_patchlevel__
>>
>> Not sure, which clang version is compiled, even clang 4.0 works well:
>> https://travis-ci.org/pevik/ltp/builds/463734307
>> Maybe we could afford to skip check (searching for __clang__).
> Per GCC compiling error, seems the root cause is tst_brk()
> parameter(tst_test.c: line#355) not using in demanded, isn't that what
> we expected?
I think we should just check invalid type for constants.

> In function ‘check_child_status’,
> inlined from ‘tst_reap_children’ at tst_test.c:371:4:
> ../include/tst_common.h:74:41: error: call to ‘tst_brk_detect_’
> declared with attribute error: tst_brk(): invalid type, please use
> TBROK/TCONF/TFAIL
> compiletime_assert(!(cond), msg, tst_brk_detect_)
> ^
> ../include/tst_common.h:79:24: note: in definition of macro ‘compiletime_assert’
> funcname_(); \
> ^
> ../include/tst_test.h:74:16: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
> BUILD_BUG_ON_MSG(!((ttype)& (TBROK | TCONF | TFAIL)), \
> ^
> tst_test.c:355:3: note: in expansion of macro ‘tst_brk’
> tst_brk(ret, "Reported by child (%i)", pid);
> ^
> make[1]: *** [tst_test.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make[1]: Leaving directory `/home/travis/build/pevik/ltp/lib'
> make: *** [lib-all] Error 2
>
Perhaps, we need to distinguish between constants and variables by __builtin_constant_p().

Best Regards,
Xiao Yang

> --
> Regards,
> Li Wang
>