From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH RFC] sync_file_range02: remove the toplimit of write back
Date: Wed, 18 Dec 2019 04:24:51 -0500 (EST) [thread overview]
Message-ID: <2104821569.17247635.1576661091375.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20191218082826.25083-1-liwang@redhat.com>
----- Original Message -----
> " The test's assumptions are fundamentally false; it thinks it can look
> at IO counters (tst_dev_bytes_written) for a disk before and after a
> system call, and attribute all of the IO seen to the system call that
> was made - this isn't necessarily correct. Other processes may generate
> IO in the background.
We create our own block device, so there shouldn't be other processes
writing to it.
> ext4 defers a lot of IO on a freshly made filesystem to the kernel -
> for example it will initialize the journal and inode tables after the
> mount
Journal was my guess as well.
> Let's remove the toplimit of write back, and think as long as we synced
> at least the expected amount, the test passes. The +10% limit seems
> arbitrary.
I think this is reasonable approach until we find better way
to measure what was synced.
Acked-by: Jan Stancek <jstancek@redhat.com>
next prev parent reply other threads:[~2019-12-18 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 8:28 [LTP] [PATCH RFC] sync_file_range02: remove the toplimit of write back Li Wang
2019-12-18 9:24 ` Jan Stancek [this message]
2019-12-18 10:13 ` Sumit Garg
2019-12-19 7:10 ` Li Wang
2019-12-19 8:51 ` Sumit Garg
2019-12-19 9:15 ` Li Wang
2019-12-31 5:25 ` Li Wang
2019-12-31 5:31 ` Sumit Garg
2020-01-02 1:45 ` Li Wang
2019-12-31 5:49 ` Yang Xu
2019-12-31 6:03 ` Li Wang
2019-12-31 7:05 ` Yang Xu
2019-12-31 7:32 ` Li Wang
2019-12-31 7:41 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2104821569.17247635.1576661091375.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox