From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] read_all: move blacklist to source
Date: Wed, 6 Nov 2019 10:28:37 -0500 (EST) [thread overview]
Message-ID: <2124877733.10763434.1573054117742.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <87o8xpdw0l.fsf@rpws.prws.suse.cz>
----- Original Message -----
> > +static char *blacklist[] = {
> > + NULL, /* reserved for -e parameter */
> > + "/sys/power/wakeup_count",
> > +};
>
> The problem with this is that it is only required if we are running as a
> privileged user. If -p is specified then it would be a bug if nobody can
> read from any of these files.
>
> So I guess we could disable the builtin blacklist if drop_privs (switch
> to nobody) is specified
Good point. I just saw your reply that you plan to send a patch, thank you.
> and run this test twice on /sys with and without
> -p.
greg-kh wasn't very happy to hear about privileged runs in the other thread.
He was suggesting whitelist approach, but I don't know how we would keep it
up to date, deal with different configs, etc.
next prev parent reply other threads:[~2019-11-06 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 12:23 [LTP] [PATCH v2 1/2] read_all: move blacklist to source Jan Stancek
2019-11-05 12:23 ` [LTP] [PATCH v2 2/2] read_all_sys: skip debugfs Jan Stancek
2019-11-05 12:38 ` [LTP] [PATCH v2 1/2] read_all: move blacklist to source Cyril Hrubis
2019-11-05 13:12 ` Jan Stancek
2019-11-05 13:14 ` Cyril Hrubis
2019-11-05 13:29 ` Jan Stancek
2019-11-06 12:33 ` Richard Palethorpe
2019-11-06 13:27 ` Cyril Hrubis
2019-11-06 14:40 ` Richard Palethorpe
2019-11-06 15:28 ` Jan Stancek [this message]
2019-11-07 10:33 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2124877733.10763434.1573054117742.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox