From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Fix mmap01 testcase on hppa architecture
Date: Tue, 13 Jun 2017 07:18:35 -0400 (EDT) [thread overview]
Message-ID: <2130257221.33914320.1497352715953.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170609145328.GA7129@ls3530>
----- Original Message -----
> The mmap() syscall to map a file at any given page-aligned address (via the
> MAP_FIXED flag) can fail on the hppa architecture due to cache colouring
> requirements of the architecture.
>
> This patch drops the MAP_FIXED flag and thus maps the file instead at
> some convenient address based on the hint as given by the addr
> parameter.
It looks like we don't need addr at all. Test is remapping part
of heap with MAP_FIXED, which looks risky. I'd drop that page
initialisation inside heap too. Now, without MAP_FIXED, it's
just completely unrelated page. What do you think?
Regards,
Jan
next prev parent reply other threads:[~2017-06-13 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 14:53 [LTP] [PATCH] Fix mmap01 testcase on hppa architecture Helge Deller
2017-06-13 11:18 ` Jan Stancek [this message]
2017-06-16 13:55 ` Helge Deller
2017-06-16 14:03 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2130257221.33914320.1497352715953.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox