From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] pty04: Retry reads when short
Date: Tue, 12 May 2020 15:44:48 -0400 (EDT) [thread overview]
Message-ID: <2136651671.12186381.1589312688262.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200512154935.GA24478@dell5510>
----- Original Message -----
> Hi Richard,
>
> > Even though reads are blocking and packets are flipped into the netdevice
> > buffer whole, it seems read may return before a full packet is read into
> > user
> > land. Retrying read should prevent timeouts and read failures on some
> > machines.
>
> > Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> > Reported-by: Jan Stancek <jstancek@redhat.com>
> > Cc: Petr Vorel <pvorel@suse.cz>
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> Thanks for taking care of this.
ACK, I'll update github issue when this runs for a while with recent upstream kernels.
> It's still possible to reproduce timeout just with higher -i (-i10),
> but it's an improvement.
>
> Kind regards,
> Petr
>
>
next prev parent reply other threads:[~2020-05-12 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 14:28 [LTP] [PATCH 1/2] pty04: Remove unnecessary volatile and style fix Richard Palethorpe
2020-05-12 14:28 ` [LTP] [PATCH 2/2] pty04: Retry reads when short Richard Palethorpe
2020-05-12 15:44 ` Cyril Hrubis
2020-05-12 15:49 ` Petr Vorel
2020-05-12 19:44 ` Jan Stancek [this message]
2020-05-13 8:23 ` [LTP] [PATCH 1/2] pty04: Remove unnecessary volatile and style fix Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2136651671.12186381.1589312688262.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox