From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1V2c7h-0005F8-2E for ltp-list@lists.sourceforge.net; Fri, 26 Jul 2013 07:07:33 +0000 Received: from mx4-phx2.redhat.com ([209.132.183.25]) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1V2c7f-0001Vl-3N for ltp-list@lists.sourceforge.net; Fri, 26 Jul 2013 07:07:32 +0000 Date: Fri, 26 Jul 2013 03:07:21 -0400 (EDT) From: Jan Stancek Message-ID: <221551028.6361858.1374822441673.JavaMail.root@redhat.com> In-Reply-To: <1374807380-20319-1-git-send-email-gaowanlong@cn.fujitsu.com> References: <1374807380-20319-1-git-send-email-gaowanlong@cn.fujitsu.com> MIME-Version: 1.0 Subject: Re: [LTP] [PATCH 1/3] pthread_rwlock_rdlock:2-1: do not test on glibc List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Wanlong Gao Cc: LTP ----- Original Message ----- > From: "Wanlong Gao" > To: "LTP" > Cc: "Cyril Hrubis" , "Caspar Zhang" , "Garrett Cooper" , > "Mike Frysinger" , jstancek@redhat.com, "Wanlong Gao" > Sent: Friday, 26 July, 2013 4:56:18 AM > Subject: [PATCH 1/3] pthread_rwlock_rdlock:2-1: do not test on glibc > > Since the reader can always acquire the rwlock if there's not a writer > held the lock. > > Signed-off-by: Wanlong Gao Hi, I agree that these 3 fail by default on glibc at the moment. Since we are adding a GLIBC ifdef, I'm wondering if we could use glibc specific api to change default behaviour with pthread_rwlockattr_setkind_np() and still run the testcase. Regards, Jan > --- > .../conformance/interfaces/pthread_rwlock_rdlock/2-1.c | 6 > ++++++ > 1 file changed, 6 insertions(+) > > diff --git > a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_rdlock/2-1.c > b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_rdlock/2-1.c > index c6c1412..62a4b3b 100644 > --- > a/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_rdlock/2-1.c > +++ > b/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_rdlock/2-1.c > @@ -141,6 +141,12 @@ int main(void) > return PTS_UNSUPPORTED; > #endif > > +#ifdef __GLIBC__ > + printf("The reader can always acquire rwlock if there's" > + " not a writer held this lock in glibc\n"); > + return PTS_UNTESTED; > +#endif > + > int cnt = 0; > pthread_t rd_thread, wr_thread; > int priority; > -- > 1.8.3.3.754.g9c3c367 > > ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list