From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] shmctl01: don't use hardcoded index == 0 for SHM_STAT test
Date: Tue, 21 May 2019 09:49:23 -0400 (EDT) [thread overview]
Message-ID: <224303782.23845756.1558446563195.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190521095833.GA12205@rei>
----- Original Message -----
> Hi!
> > +static void func_sstat_setup(void)
> > +{
> > + struct shm_info tmp;
> > + int ret;
> > +
> > + ret = shmctl(shm_id_1, SHM_INFO, (void *)&tmp);
> > + if (ret < 0)
> > + tst_resm(TFAIL|TERRNO, "shmctl(SHM_INFO)");
>
> I wonder if it makes sense to continue here if shmctl() has failed,
> maybe we should do tst_brkm(TBROK ...) instead.
It is 'setup phase', but it also is kind-of test for shmctl() as well.
We don't risk much if we continue, worst case is we get one more fail.
@Petr: Do you have any preference?
>
> Otherwise it looks good, acked.
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
next prev parent reply other threads:[~2019-05-21 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 19:08 [LTP] [PATCH] shmctl01: don't use hardcoded index == 0 for SHM_STAT test Jan Stancek
2019-05-20 19:58 ` Petr Vorel
2019-05-21 9:58 ` Cyril Hrubis
2019-05-21 13:49 ` Jan Stancek [this message]
2019-05-21 14:10 ` Petr Vorel
2019-05-21 16:02 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224303782.23845756.1558446563195.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox