From: Avinesh Kumar <akumar@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] tst_test: Document @message, @scall, @sample
Date: Tue, 25 Jun 2024 17:23:19 +0200 [thread overview]
Message-ID: <2272693.vFx2qVVIhK@localhost> (raw)
In-Reply-To: <20240620060203.558528-1-pvorel@suse.cz>
Hi,
Reviewed-by: Avinesh Kumar <akumar@suse.de>
On Thursday, June 20, 2024 8:02:03 AM GMT+2 you wrote:
> All undocumented members are in the library "undescribed",
> better to document the purpose.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> include/tst_test.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/tst_test.h b/include/tst_test.h
> index 8dc20d110..20960e9b9 100644
> --- a/include/tst_test.h
> +++ b/include/tst_test.h
> @@ -428,6 +428,10 @@ struct tst_ulimit_val {
> * can be set. May be executed several times if test was passed '-i'
> * or '-d' command line parameters.
> *
> + * @scall: Internal only (timer measurement library).
> + *
> + * @sample: Internal only (timer measurement library).
> + *
> * @resource_files: A NULL terminated array of filenames that will be copied
> * to the test temporary directory from the LTP datafiles
> * directory.
> @@ -642,6 +646,8 @@ int main(int argc, char *argv[])
> /**
> * TST_TEST_TCONF() - Exit tests with a TCONF message.
> *
> + * @message: Error message (the reason to skip test).
> + *
> * This macro is used in test that couldn't be compiled either because current
> * CPU architecture is unsupported or because of missing development libraries.
> */
>
Regards,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-06-25 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 6:02 [LTP] [PATCH 1/1] tst_test: Document @message, @scall, @sample Petr Vorel
2024-06-25 15:23 ` Avinesh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2272693.vFx2qVVIhK@localhost \
--to=akumar@suse.de \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox