Re: [LTP] [PATCH 1/1] keyctl05: Require root

[Avinesh Kumar <akumar@suse.de>]

Hi,

Reviewed-by: Avinesh Kumar <akumar@suse.de>


On Monday, January 22, 2024 7:38:30 AM CET Petr Vorel wrote:
> Modprobe always require root.
> 
> Fixes: f4e132233 ("keyctl05: Add modprobe dns_resolver")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> I hate require root for setup work, but in this case is needed in order
> to get dns_resolver tested. I'm sorry to forget on this.
> 
> Kind regards,
> Petr
> 
>  testcases/kernel/syscalls/keyctl/keyctl05.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/testcases/kernel/syscalls/keyctl/keyctl05.c
> b/testcases/kernel/syscalls/keyctl/keyctl05.c index a79a5763b..78ac490da
> 100644
> --- a/testcases/kernel/syscalls/keyctl/keyctl05.c
> +++ b/testcases/kernel/syscalls/keyctl/keyctl05.c
> @@ -228,6 +228,7 @@ static void do_test(unsigned int i)
>  }
> 
>  static struct tst_test test = {
> +	.needs_root = 1,
>  	.tcnt = 3,
>  	.setup = setup,
>  	.test = do_test,


Regards,
Avinesh



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp