Re: [LTP] [PATCH 2/3] isofs.sh: be more quiet

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1064 bytes --]

On Fri 21 Mar 2014 17:43:29 Stanislav Kholmanskikh wrote:
> On 03/21/2014 02:44 PM, Stanislav Kholmanskikh wrote:
> > I think that according to the patch the described behaviour is
> > absolutely expected. Therefore It would be better to leave "ls -lR" in
> > the test or insert a 'sleep' instead. In this case we would use no more
> > than 2 loop devices per iteration.
> 
> I suppose it would be a better solution (and without any waitings):
> 
> loop_dev=$(losetup --show -f isofs.iso)
> # do mount and other stuff
> # do umount
> while /bin/true; do
>      out=$(losetup -d "$loop_dev" 2>&1)
> 
>      if echo "$out" | grep -q -i "No such device"; then
>           break
>      fi
> done
> 
> This way we doesn't depend on asynchrony in the loop-driver code.

that might work.  certainly the current code, if it's trying to make the 
script "sleep" in hopes the device is no longer in use by udev/whatever, is 
also broken.

make sure to use LC_ALL=C though when running losetup so the localization 
doesn't screw up the grep.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 79 bytes --]

------------------------------------------------------------------------------

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list