From: Avinesh Kumar <akumar@suse.de>
To: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] syscalls/munmap02: Refactor the test using new LTP API
Date: Wed, 10 Jan 2024 10:45:52 +0100 [thread overview]
Message-ID: <2381416.cqcTQP2oNQ@localhost> (raw)
In-Reply-To: <874jhobua2.fsf@suse.de>
On Tuesday, November 14, 2023 9:37:16 AM CET Richard Palethorpe wrote:
> Hello,
>
> Andrea Cervesato via ltp <ltp@lists.linux.it> writes:
> > Hi!
> >
> > munmap01 and munmap02 looks quite similar. The refactoring is good to
> > me, but maybe we can merge them into a single test using 2 different
> > test cases, where the first is mapping a certain portion of the file
> > and the second an another.
>
> Yes, these should be merged. Otherwise the rewrite looks good.
>
Hi,
sorry for not responding to this review earlier.
But may I request for merging these patches if the refactoring is fine. I agree
that these both should be combined to single test, and I would like to do
that, but maybe in the second step after upcoming release.
Thank you,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-01-10 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 10:08 [LTP] [PATCH 1/2] syscalls/munmap01: Refactor the test using new LTP API Avinesh Kumar
2023-09-13 10:08 ` [LTP] [PATCH 2/2] syscalls/munmap02: " Avinesh Kumar
2023-09-13 11:18 ` Andrea Cervesato via ltp
2023-11-14 8:37 ` Richard Palethorpe
2024-01-10 9:45 ` Avinesh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2381416.cqcTQP2oNQ@localhost \
--to=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox