public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Fix prctl02
Date: Thu, 23 Jan 2020 09:55:34 -0500 (EST)	[thread overview]
Message-ID: <239304412.3515101.1579791334045.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200123143137.23214-1-mdoucha@suse.cz>



----- Original Message -----
> The prctl() system call takes 5 integer arguments but only 3 of them were
> passed in the test. This means that the system call read random garbage
> from stack in place of the two missing arguments and failed even on some
> perfectly valid combinations of arguments on some platforms.
> 
> - Fixed arguments in test case 9 (second PR_SET_NO_NEW_PRIVS)
> - Dropped test case 13 (PR_CAP_AMBIENT) because the args are valid
> - Dropped test case 14 (PR_GET_SPECULATION_CTRL) because the args are valid

Can we make them invalid and keep the test cases?
For example:
 PR_CAP_AMBIENT arg2 could be num_invalid
 PR_GET_SPECULATION_CTRL arg3 could be num_1

The rest looks good to me.


  reply	other threads:[~2020-01-23 14:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23 14:31 [LTP] [PATCH] Fix prctl02 Martin Doucha
2020-01-23 14:55 ` Jan Stancek [this message]
2020-01-23 15:18   ` [LTP] [PATCH v2] " Martin Doucha
2020-01-23 23:54     ` Jan Stancek
2020-01-24 11:10     ` Yang Xu
2020-01-24 12:48       ` Cyril Hrubis
2020-01-24 13:06         ` Yang Xu
2020-01-24 14:14     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=239304412.3515101.1579791334045.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox