From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC] [PATCH] syslog-lib.sh: Produce TCONF instead of TBROK for journald
Date: Thu, 4 May 2017 14:59:00 -0400 (EDT) [thread overview]
Message-ID: <240867630.7382524.1493924340310.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170502181749.16375-1-chrubis@suse.cz>
----- Original Message -----
> If there is no traditional syslog daemon installed these testcaess exit
> with TBROK which is not correct since these tests are simply not
> applicable if no syslog daemon is installed.
>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
> testcases/kernel/syscalls/syslog/syslog-lib.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/syslog/syslog-lib.sh
> b/testcases/kernel/syscalls/syslog/syslog-lib.sh
> index e166d3a45..35c13daf7 100755
> --- a/testcases/kernel/syscalls/syslog/syslog-lib.sh
> +++ b/testcases/kernel/syscalls/syslog/syslog-lib.sh
> @@ -86,8 +86,8 @@ EOF
> )
> fi
> else
> - tst_resm TBROK "Couldn't find syslogd, syslog-ng or rsyslogd"
> - cleanup 1
> + tst_resm TCONF "Couldn't find syslogd, syslog-ng or rsyslogd"
> + cleanup 32
> fi
>
> # Back up configuration file
> --
> 2.12.2
ACK
Regards,
Jan
next prev parent reply other threads:[~2017-05-04 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 18:17 [LTP] [RFC] [PATCH] syslog-lib.sh: Produce TCONF instead of TBROK for journald Cyril Hrubis
2017-05-04 18:59 ` Jan Stancek [this message]
2017-05-05 9:11 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=240867630.7382524.1493924340310.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox