Re: [LTP] [PATCH] Small fixes (some bashisms and probable typos)

Re: [LTP] [PATCH] Small fixes (some bashisms and probable typos)

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 115 bytes --]

other than the minor things i mentioned specifically, the rest of your changes 
look fine to me.  thanks!
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 300 bytes --]

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Small fixes (some bashisms and probable typos)

[Jiří Paleček]

On Wed, 02 Dec 2009 00:20:36 +0100, Mike Frysinger <vapier@gentoo.org>  
wrote:

> other than the minor things i mentioned specifically, the rest of your  
> changes
> look fine to me.  thanks!

OK. I'll resend the two.

   Jiri Palecek


-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Small fixes (some bashisms and probable typos)

[Subrata Modak]

On Wed, 2009-12-02 at 00:42 +0100, Jiří Paleček wrote: 
> On Wed, 02 Dec 2009 00:20:36 +0100, Mike Frysinger <vapier@gentoo.org>  
> wrote:
> 
> > other than the minor things i mentioned specifically, the rest of your  
> > changes
> > look fine to me.  thanks!
> 
> OK. I'll resend the two.

This resend is yet to arrive ;-)

Regards--
Subrata

> 
>    Jiri Palecek
> 
> 


------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Small fixes (some bashisms and probable typos)

[Jiří Paleček]

Subrata Modak wrote:
> 
> On Wed, 2009-12-02 at 00:42 +0100, Jiří Paleček wrote: 
>> On Wed, 02 Dec 2009 00:20:36 +0100, Mike Frysinger <vapier@gentoo.org>  
>> wrote:
>> 
>> > other than the minor things i mentioned specifically, the rest of your  
>> > changes
>> > look fine to me.  thanks!
>> 
>> OK. I'll resend the two.
> 
> This resend is yet to arrive ;-)
> 

This resend will not arrive, because I believe Mike didn't object against
this one. By "the two", I referred to the "success condition/echo01" and
"set -u" patches (which were both accepted in the modified version).

  Jiri Palecek
-- 
View this message in context: http://old.nabble.com/-PATCH--Small-fixes-%28some-bashisms-and-probable-typos%29-tp26600589p26635869.html
Sent from the ltp-list mailing list archive at Nabble.com.


------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH] Small fixes (some bashisms and probable typos)

[Jiri Palecek]

Signed-off-by: Jiri Palecek <jpalecek@web.de>
---
 .../kernel/controllers/cpuacct/run_cpuacct_test.sh |    6 +++---
 testcases/network/nfs/nfsstat01/nfsstat01          |    2 +-
 testcases/network/tcp_cmds/rdist/rdist01           |    2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh b/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh
index 38b2ab6..648ead5 100755
--- a/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh
+++ b/testcases/kernel/controllers/cpuacct/run_cpuacct_test.sh
@@ -246,7 +246,7 @@ echo "TEST STARTED: Please avoid using system while this test executes";
 status=0
 case ${TEST_NUM} in
 	"1" )
-		ls $PWD/cpuacct_task01 &> /dev/null
+		ls $PWD/cpuacct_task01 > /dev/null 2>&1
 		if [ $? -ne 0 ]
 		then
 		        echo "TFAIL Task file cpuacct_task01.c not compiled"
@@ -314,7 +314,7 @@ case ${TEST_NUM} in
                         exit -1
                 fi
 
-                ls $PWD/cpuacct_task01 &> /dev/null
+                ls $PWD/cpuacct_task01 > /dev/null 2>&1
                 if [ $? -ne 0 ]
                 then
                         echo "TFAIL Task file cpuacct_task01.c not compiled"
@@ -323,7 +323,7 @@ case ${TEST_NUM} in
 			task_kill 2> /dev/null
 		        exit -1
                 fi
-		for (( m=0 ; m<=$num_online_cpus ; m++ ))
+		for m in $(seq 0 $num_online_cpus)
 		do
 			nr_tasks
         	        echo $pid > $cg_path/group_1/group_11/tasks
diff --git a/testcases/network/nfs/nfsstat01/nfsstat01 b/testcases/network/nfs/nfsstat01/nfsstat01
index 39d73cd..4d2aa20 100755
--- a/testcases/network/nfs/nfsstat01/nfsstat01
+++ b/testcases/network/nfs/nfsstat01/nfsstat01
@@ -48,7 +48,7 @@ HOST=`hostname`
 CLEANUP=${CLEANUP:="ON"}
 VERSION=${VERSION:=2}
 TESTDIR=${TESTDIR:=/tmp/$TC$PID.testdir}
-NFS_TYPE=${NFS_TYPE:nfs}
+NFS_TYPE=${NFS_TYPE:-nfs}
 
 if [ "x$NFS_TYPE" != "xnfs4" ]; then
     OPTS=${OPTS:="-o vers=$VERSION "}
-- 
1.6.4.3




------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list