From: Avinesh Kumar <akumar@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/pipe06: Rewrite the test using new LTP API
Date: Tue, 18 Jul 2023 14:57:29 +0530 [thread overview]
Message-ID: <2691616.mvXUDI8C0e@localhost> (raw)
In-Reply-To: <20230718082313.GA1140910@pevik>
Hi Petr,
On Tuesday, July 18, 2023 1:53:13 PM IST Petr Vorel wrote:
> Hi Avinesh,
>
> > testcases/kernel/syscalls/pipe/pipe06.c | 133 ++++++------------------
>
> ...
>
> > +static void setup(void)
> >
> > {
> >
> > + int max_fds;
> >
> > - /* reset tst_count in case we are looping */
> > - tst_count = 0;
> > + max_fds = getdtablesize();
> > + tst_res(TINFO, "getdtablesize() = %d", max_fds);
> > + opened_fds = SAFE_MALLOC(max_fds * sizeof(int));
>
> You don't free opened_fds in cleanup, that would be a memory leak.
Thank you for reviewing and catching this issue. I've sent a v2 with
your suggested fix.
Regards,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-07-18 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 15:33 [LTP] [PATCH] syscalls/pipe06: Rewrite the test using new LTP API Avinesh Kumar
2023-07-18 8:23 ` Petr Vorel
2023-07-18 9:27 ` Avinesh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2691616.mvXUDI8C0e@localhost \
--to=akumar@suse.de \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox